build: fix commit-queue default branch#38998
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`github.repository.default_branch` is not a valid context variable, and GitHub doesn't have a context or environment variable containing the default branch. It does have `github.ref` and `$GITHUB_REF`, which contains the default branch _reference_ (as in `refs/heads/<branch>`), so we can use that and remove the `refs/heads/` prefix.
github-actionsbot added the meta 
ContributorAuthor
mmarchini commented Jun 10, 2021
Fast track? |
ContributorAuthor
mmarchini commented Jun 10, 2021
cc @nodejs/tsc @nodejs/commit-queue @nodejs/build |
Trott approved these changes Jun 10, 2021
Member
mcollina commented Jun 10, 2021
+1 to fast track |
ronag approved these changes Jun 10, 2021
mmarchini added the fast-track 
Contributor
Fast-track has been requested by @mmarchini. Please 👍 to approve. |
ContributorAuthor
mmarchini commented Jun 10, 2021
Landed in 52f8471 |
mmarchini added a commit that referenced this pull request Jun 10, 2021
`github.repository.default_branch` is not a valid context variable, and GitHub doesn't have a context or environment variable containing the default branch. It does have `github.ref` and `$GITHUB_REF`, which contains the default branch _reference_ (as in `refs/heads/<branch>`), so we can use that and remove the `refs/heads/` prefix. PR-URL: #38998 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
`github.repository.default_branch` is not a valid context variable, and GitHub doesn't have a context or environment variable containing the default branch. It does have `github.ref` and `$GITHUB_REF`, which contains the default branch _reference_ (as in `refs/heads/<branch>`), so we can use that and remove the `refs/heads/` prefix. PR-URL: #38998 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Merged
danielleadams pushed a commit that referenced this pull request Jun 17, 2021
`github.repository.default_branch` is not a valid context variable, and GitHub doesn't have a context or environment variable containing the default branch. It does have `github.ref` and `$GITHUB_REF`, which contains the default branch _reference_ (as in `refs/heads/<branch>`), so we can use that and remove the `refs/heads/` prefix. PR-URL: #38998 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
`github.repository.default_branch` is not a valid context variable, and GitHub doesn't have a context or environment variable containing the default branch. It does have `github.ref` and `$GITHUB_REF`, which contains the default branch _reference_ (as in `refs/heads/<branch>`), so we can use that and remove the `refs/heads/` prefix. PR-URL: #38998 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
`github.repository.default_branch` is not a valid context variable, and GitHub doesn't have a context or environment variable containing the default branch. It does have `github.ref` and `$GITHUB_REF`, which contains the default branch _reference_ (as in `refs/heads/<branch>`), so we can use that and remove the `refs/heads/` prefix. PR-URL: #38998 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
`github.repository.default_branch` is not a valid context variable, and GitHub doesn't have a context or environment variable containing the default branch. It does have `github.ref` and `$GITHUB_REF`, which contains the default branch _reference_ (as in `refs/heads/<branch>`), so we can use that and remove the `refs/heads/` prefix. PR-URL: nodejs#38998 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.repository.default_branchis not a valid context variable, andGitHub doesn't have a context or environment variable containing the
default branch. It does have
github.refand$GITHUB_REF, whichcontains the default branch reference (as in
refs/heads/<branch>),so we can use that and remove the
refs/heads/prefix.