test: avoid test timeouts on rpi#3902
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Generating 1024-bit primes on rpi test machines sometimes causes timeouts. Avoid this situation by using 256-bit primes when not running in FIPS mode.
This was referenced Nov 18, 2015
mscdex added test 
Contributor
cjihrig commented Nov 18, 2015
LGTM |
Contributor
mscdex commented Nov 18, 2015
LGTM |
Member
bnoordhuis commented Nov 18, 2015
ContributorAuthor
stefanmb commented Nov 18, 2015
Member
jasnell commented Nov 18, 2015
Landed in da9a89a |
Contributor
Fishrock123 commented Nov 18, 2015
Umm, won't this mean the whole CI tests with 256-bit primes now since it doesn't use FIPS? |
ContributorAuthor
stefanmb commented Nov 18, 2015
@Fishrock123 Correct, which is the exact situation we had before my previous commit. Separately, there has been discussion about introducing FIPS builds into CI. |
jasnell pushed a commit that referenced this pull request Nov 18, 2015
Generating 1024-bit primes on rpi test machines sometimes causes timeouts. Avoid this situation by using 256-bit primes when not running in FIPS mode. Fixes: #3881 PR-URL: #3902 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Member
jasnell commented Nov 18, 2015
Exactly, this reverts the behavior back to where it was before when FIPS is not enabled. |
MylesBorins pushed a commit that referenced this pull request Dec 1, 2015
Generating 1024-bit primes on rpi test machines sometimes causes timeouts. Avoid this situation by using 256-bit primes when not running in FIPS mode. PR-URL: #3902 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
rvagg pushed a commit that referenced this pull request Dec 4, 2015
Generating 1024-bit primes on rpi test machines sometimes causes timeouts. Avoid this situation by using 256-bit primes when not running in FIPS mode. PR-URL: #3902 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
rvagg pushed a commit that referenced this pull request Dec 5, 2015
Generating 1024-bit primes on rpi test machines sometimes causes timeouts. Avoid this situation by using 256-bit primes when not running in FIPS mode. Fixes: #3881 PR-URL: #3902 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
This was referenced Dec 8, 2015
Closed
jasnell pushed a commit that referenced this pull request Dec 17, 2015
Generating 1024-bit primes on rpi test machines sometimes causes timeouts. Avoid this situation by using 256-bit primes when not running in FIPS mode. PR-URL: #3902 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
jasnell pushed a commit that referenced this pull request Dec 23, 2015
Generating 1024-bit primes on rpi test machines sometimes causes timeouts. Avoid this situation by using 256-bit primes when not running in FIPS mode. PR-URL: #3902 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating 1024-bit primes on rpi test machines sometimes causes timeouts. We can avoid this situation by using 256-bit primes when not running in FIPS mode.
Resolves#3881.