[v14.x] deps: V8: cherry-pick b0a7f5691113

[targos]

Original commit message:

Update to ICU68-1 ICU68-1 change the output skeleton format. So we need to change resolvedOptions code for 68 migration. Chromium roll https://chromium-review.googlesource.com/c/chromium/src/+/2474093 Bug: v8:10945 Change-Id: I3b2c7fbe8abb22df8fa51287c498ca3245b8c55b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2477431 Commit-Queue: Frank Tang <[email protected]> Reviewed-by: Jakob Kummerow <[email protected]> Reviewed-by: Shu-yu Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{#70972} 

Refs: v8/v8@b0a7f56
Fixes: #39050

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/38645/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4057/

[targos]

$ ./node Welcome to Node.js v14.17.2-pre. Type ".help" for more information. > (new Intl.NumberFormat('en-US',{style: 'percent'})).resolvedOptions(){locale: 'en-US', numberingSystem: 'latn', style: 'percent', minimumIntegerDigits: 1, minimumFractionDigits: 0, maximumFractionDigits: 0, useGrouping: true, notation: 'standard', signDisplay: 'auto' } 

[targos]

@richardlau I guess this is actually another change that's incompatible with ICU 65 (nodejs/Release#679) ?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/39067/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/39068/

[richardlau]

@richardlau I guess this is actually another change that's incompatible with ICU 65 (nodejs/Release#679) ?

I suspect so. We now have a sub-job of node-test-commit-linux-containered to test against the minimum ICU. I rebased this PR and started a CI but just realized that I should have waited until after I land #39068 (which I'll do if the CI for that passes) as that will move the minimum back to ICU 65 (it's currently 67).

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/39070/

[richardlau]

Hmm well https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_icu_x64/27884/ passed built against ICU 65 but that probably indicating we have no test coverage for #39050.

[richardlau]

Yeah, we don't currently have test coverage here. I've opened #39401 to add a regression test for #39050 which we should probably land together with/as part of this PR for v14.x-staging.

[targos]

Rebased and added the commit from #39401

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/39103/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4149/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/39106/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/39114/

[richardlau]

So the test added in #39401 passes on both minimum ICU and the one in the source tree. Unfortunately two of V8's intl tests are failing,
https://ci.nodejs.org/job/node-test-commit-v8-linux/4154/nodes=benchmark-ubuntu1604-intel-64,v8test=v8test/console

21:27:24 === intl/regress-1074578 === 21:27:24 --- stdout --- 21:27:24 /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/intl/assert.js:105: Error: Failure: expected <March 8, 2020 at 5:00:00 PM MST>, found <March 8, 2020 at 5:00:00 PM PDT>. 21:27:24 throw new Error(message); 21:27:24 ^ 21:27:24 Error: Failure: expected <March 8, 2020 at 5:00:00 PM MST>, found <March 8, 2020 at 5:00:00 PM PDT>. 21:27:24 at fail (/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/intl/assert.js:105:9) 21:27:24 at assertEquals (/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/intl/assert.js:114:5) 21:27:24 at /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/intl/regress-1074578.js:34:1 21:27:24 Command: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/x64.release/d8 --test /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/intl/assert.js /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/intl/utils.js /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/intl/regress-1074578.js --random-seed=1636937679 --nohard-abort --testing-d8-test-runner --allow-natives-syntax 21:27:24 === intl/regress-7982 === 21:27:24 --- stdout --- 21:27:24 /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/intl/assert.js:105: Error: Failure: expected <zh-Hant-u-ca-chinese>, found <zh-TW-u-ca-chinese>. 21:27:24 throw new Error(message); 21:27:24 ^ 21:27:24 Error: Failure: expected <zh-Hant-u-ca-chinese>, found <zh-TW-u-ca-chinese>. 21:27:24 at fail (/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/intl/assert.js:105:9) 21:27:24 at assertEquals (/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/intl/assert.js:114:5) 21:27:24 at /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/intl/regress-7982.js:20:1 21:27:24 Command: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/x64.release/d8 --test /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/intl/assert.js /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/intl/utils.js /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/intl/regress-7982.js --random-seed=1636937679 --nohard-abort --testing-d8-test-runner --allow-natives-syntax 21:27:24 21:27:24 === 21:27:24 === 2 tests failed 21:27:24 === 

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/39142/

[richardlau]

I think the two test failures would be addressed by

• https://chromium-review.googlesource.com/c/v8/v8/+/2476681
• https://chromium-review.googlesource.com/c/v8/v8/+/2237353 (although perhaps this might have to be cherry-picked before v8/v8@b0a7f56 as it also changes the Chromium ICU hash)

[targos]

I backported these two commits.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/39148/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4157/

[targos]

Seems good now!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/39157/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/39158/

[richardlau]

Landed in 0d2b4b7...697f978.