crypto: use compatible ecdh function#39054
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actionsbot added c++ 
Collaborator
nodejs-github-bot commented Jun 16, 2021
Collaborator
nodejs-github-bot commented Jun 16, 2021
fhinkel approved these changes Jun 16, 2021
Member
addaleax commented Jun 16, 2021
Maybe it also makes sense to add a comment here so that nobody accidentally undoes this? |
codebytereforce-pushed the use-boringssl-compat-ecdh branch from 365d4b6 to 001c143Compare
addaleax approved these changes Jun 16, 2021
Collaborator
nodejs-github-bot commented Jun 17, 2021
Collaborator
nodejs-github-bot commented Jun 17, 2021
Uh oh!
There was an error while loading. Please reload this page.
codebytereforce-pushed the use-boringssl-compat-ecdh branch from 001c143 to e0b0d4bCompare
tniessen approved these changes Jun 29, 2021
Member
tniessen left a comment
tniessen left a comment There was a problem hiding this comment.
Thank you, I think that's much cleaner 😃
Collaborator
nodejs-github-bot commented Jun 29, 2021
Collaborator
nodejs-github-bot commented Jun 29, 2021
Collaborator
nodejs-github-bot commented Jun 29, 2021
Collaborator
nodejs-github-bot commented Jun 29, 2021
Collaborator
nodejs-github-bot commented Jun 29, 2021
MemberAuthor
codebytere commented Jun 30, 2021
Landed in 5830449 |
codebytere added a commit that referenced this pull request Jun 30, 2021
PR-URL: #39054 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2021
PR-URL: #39054 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Jul 14, 2021
jkleinsc added a commit to electron/electron that referenced this pull request Jul 15, 2021
* chore: bump node in DEPS to v16.4.2 * chore: update patches * ci: run main and remote woa tests separately * chore: bump node in DEPS to v16.5.0 * build: restore libplatform headers in distribution nodejs/node#39288 * build: pass directory instead of list of files to js2c.py nodejs/node#39069 * chore: various BoringSSL/OpenSSL upstreams - nodejs/node#39136 - nodejs/node#39138 - nodejs/node#39054 * test: move debugger test case to parallel nodejs/node#39300 * chore: fixup patch indices * build: pass directory instead of list of files to js2c.py nodejs/node#39069 Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <[email protected]> Co-authored-by: Shelley Vohr <[email protected]>
BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
* chore: bump node in DEPS to v16.4.2 * chore: update patches * ci: run main and remote woa tests separately * chore: bump node in DEPS to v16.5.0 * build: restore libplatform headers in distribution nodejs/node#39288 * build: pass directory instead of list of files to js2c.py nodejs/node#39069 * chore: various BoringSSL/OpenSSL upstreams - nodejs/node#39136 - nodejs/node#39138 - nodejs/node#39054 * test: move debugger test case to parallel nodejs/node#39300 * chore: fixup patch indices * build: pass directory instead of list of files to js2c.py nodejs/node#39069 Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <[email protected]> Co-authored-by: Shelley Vohr <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs electron/electron#27688.
This PR switches
ECDH::SetPrivateKeyto use a compatible ECDH function - the previously used one is a no-op in BoringSSL. Also change an algorithm in the associated test suite to one supported by BoringSSL so we can run more smoke tests.