lib: make lazyDOMException more common#39105
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actionsbot added lib / src 
aduh95 reviewed Jun 21, 2021
Uh oh!
There was an error while loading. Please reload this page.
aduh95 reviewed Jun 21, 2021
Comment on lines +447 to +448
| if(DOMException===undefined) | ||
| DOMException=internalBinding('messaging').DOMException; |
Contributor
There was a problem hiding this comment.
Suggested change
| if(DOMException===undefined) | |
| DOMException=internalBinding('messaging').DOMException; | |
| DOMException??=internalBinding('messaging').DOMException; |
Contributor
There was a problem hiding this comment.
I find ??= more readable and concise than the if statement, feel free to disagree and/or disregard.
aduh95 approved these changes Jun 21, 2021
| letDOMException; | ||
| constlazyDOMException=hideStackFrames((message,name)=>{ | ||
| if(DOMException===undefined) | ||
| DOMException=internalBinding('messaging').DOMException; |
Member
There was a problem hiding this comment.
I think it's good to hoist this out of the crypto util and make it more universal in the code base, but I am wondering, why do we want to make this lazy?
Contributor
There was a problem hiding this comment.
Probably to avoid building the JS function until we're on the error path?
Collaborator
nodejs-github-bot commented Jun 23, 2021
Collaborator
nodejs-github-bot commented Jun 24, 2021
ContributorAuthor
XadillaX commented Jun 28, 2021
Landed in 2de139b |
XadillaX added a commit that referenced this pull request Jun 28, 2021
PR-URL: #39105 Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2021
PR-URL: #39105 Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.