Skip to content

Conversation

@cjihrig
Copy link
Contributor

The module loading system will not append node_modules to a
path already ending in node_modules. This used to be documented,
but it was lost.

Fixes: #3873

@jasnell
Copy link
Member

LGTM

@jasnelljasnell added doc Issues and PRs related to the documentations. lts-watch-v4.x labels Nov 19, 2015
@targos
Copy link
Member

LGTM

@mscdexmscdex added the module Issues and PRs related to the module subsystem. label Nov 19, 2015
cjihrig added a commit that referenced this pull request Nov 19, 2015
The module loading system will not append node_modules to a path already ending in node_modules. This used to be documented, but it was lost. Fixes: #3873 PR-URL: #3920 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
@cjihrigcjihrig closed this Nov 19, 2015
@cjihrigcjihrig deleted the lookup-docs branch November 19, 2015 18:12
cjihrig added a commit that referenced this pull request Dec 1, 2015
The module loading system will not append node_modules to a path already ending in node_modules. This used to be documented, but it was lost. Fixes: #3873 PR-URL: #3920 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
cjihrig added a commit that referenced this pull request Dec 4, 2015
The module loading system will not append node_modules to a path already ending in node_modules. This used to be documented, but it was lost. Fixes: #3873 PR-URL: #3920 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
cjihrig added a commit that referenced this pull request Dec 5, 2015
The module loading system will not append node_modules to a path already ending in node_modules. This used to be documented, but it was lost. Fixes: #3873 PR-URL: #3920 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
@jasnelljasnell mentioned this pull request Dec 17, 2015
cjihrig added a commit that referenced this pull request Dec 17, 2015
The module loading system will not append node_modules to a path already ending in node_modules. This used to be documented, but it was lost. Fixes: #3873 PR-URL: #3920 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
cjihrig added a commit that referenced this pull request Dec 23, 2015
The module loading system will not append node_modules to a path already ending in node_modules. This used to be documented, but it was lost. Fixes: #3873 PR-URL: #3920 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.moduleIssues and PRs related to the module subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@cjihrig@jasnell@targos@mscdex@MylesBorins