Skip to content

Conversation

@Trott
Copy link
Member

@TrottTrott commented Jul 2, 2021

Remove code that made a check more lenient to account for a known issue
that is no longer reproducible.

Refs: nodejs/node-inspect#35

@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 2, 2021
@Trott
Copy link
MemberAuthor

Trott commented Jul 2, 2021

@github-actionsgithub-actionsbot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 2, 2021
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 2, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@TrottTrott requested a review from hybristJuly 5, 2021 01:22
Remove code that made a check more lenient to account for a known issue that is no longer reproducible. Refs: nodejs/node-inspect#35 PR-URL: nodejs#39238 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jan Krems <[email protected]>
@Trott
Copy link
MemberAuthor

Trott commented Jul 6, 2021

Landed in 12622c5

@TrottTrott merged commit 12622c5 into nodejs:masterJul 6, 2021
@TrottTrott deleted the preserve-breaks branch July 6, 2021 04:23
targos pushed a commit that referenced this pull request Jul 11, 2021
Remove code that made a check more lenient to account for a known issue that is no longer reproducible. Refs: nodejs/node-inspect#35 PR-URL: #39238 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jan Krems <[email protected]>
@targostargos mentioned this pull request Jul 13, 2021
targos pushed a commit that referenced this pull request Sep 4, 2021
Remove code that made a check more lenient to account for a known issue that is no longer reproducible. Refs: nodejs/node-inspect#35 PR-URL: #39238 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jan Krems <[email protected]>
@targostargos mentioned this pull request Sep 4, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@nodejs-github-bot@hybrist@cjihrig