Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
perf: remove duplicate codes#39239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
perf: remove duplicate codes #39239
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ronag approved these changes Jul 3, 2021
jasnell approved these changes Jul 8, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 8, 2021
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 10, 2021
22 tasks
This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented Nov 25, 2021
This was referenced Nov 26, 2021
Collaborator
nodejs-github-bot commented Dec 10, 2021
47 tasks
This was referenced Dec 20, 2021
Collaborator
nodejs-github-bot commented Dec 21, 2021
This was referenced Dec 22, 2021
Collaborator
nodejs-github-bot commented Dec 24, 2021
This was referenced Dec 25, 2021
Collaborator
nodejs-github-bot commented Dec 27, 2021
Commit Queue failed- Loading data for nodejs/node/pull/39239 ✔ Done loading data for nodejs/node/pull/39239 ----------------------------------- PR info ------------------------------------ Title perf: remove duplicate codes (#39239) Author Shaw <[email protected]> (@xiaoxiaojx, first-time contributor) Branch xiaoxiaojx:patch-1 -> nodejs:master Labels http, author ready Commits 1 - remove duplicate codes Committers 1 - kaiduo PR-URL: https://github.com/nodejs/node/pull/39239 Reviewed-By: Robert Nagy Reviewed-By: James M Snell Reviewed-By: Yongsheng Zhang ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/39239 Reviewed-By: Robert Nagy Reviewed-By: James M Snell Reviewed-By: Yongsheng Zhang -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 02 Jul 2021 18:36:14 GMT ✔ Approvals: 3 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/39239#pullrequestreview-698577770 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/39239#pullrequestreview-701561527 ✔ - Yongsheng Zhang (@ZYSzys): https://github.com/nodejs/node/pull/39239#pullrequestreview-829514403 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2021-12-24T15:38:29Z: https://ci.nodejs.org/job/node-test-pull-request/41648/ - Querying data for job/node-test-pull-request/41648/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD 9a85efaa7f..077c75beae master -> origin/master ✔ origin/master is now up-to-date master is out of sync with origin/master. Mismatched commits: - ba1b7a2749 tls: permit null as a pfx value - 077c75beae tls: permit null as a pfx value -------------------------------------------------------------------------------- HEAD is now at 077c75beae tls: permit null as a pfx value ✔ Reset to origin/master - Downloading patch for 39239 From https://github.com/nodejs/node * branch refs/pull/39239/merge -> FETCH_HEAD ✔ Fetched commits as 077c75beaecc..00342b335efa -------------------------------------------------------------------------------- [master 28ed5ff2f2] remove duplicate codes Author: Shaw <[email protected]> Date: Sat Jul 3 02:33:35 2021 +0800 1 file changed, 1 deletion(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- remove duplicate codeshttps://github.com/nodejs/node/actions/runs/1627255427 |
This was referenced Dec 28, 2021
Trott pushed a commit to xiaoxiaojx/node that referenced this pull request Jan 5, 2022
This line of code has been implemented in the prepareError function. PR-URL: nodejs#39239 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Member
Trott commented Jan 5, 2022 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Landed in bad65ea. Thanks for the contribution! 🎉 |
This line of code has been implemented in the prepareError function. PR-URL: nodejs#39239 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
targos pushed a commit that referenced this pull request Jan 14, 2022
This line of code has been implemented in the prepareError function. PR-URL: #39239 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
This line of code has been implemented in the prepareError function. PR-URL: #39239 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
This line of code has been implemented in the prepareError function. PR-URL: nodejs#39239 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
This line of code has been implemented in the prepareError function. PR-URL: #39239 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author readyPRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failedAn error occurred while landing this pull request using GitHub Actions. httpIssues or PRs related to the http subsystem.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line of code has been implemented in the prepareError function