Skip to content

test: use common.PORT instead of hardcoded port number#39298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Trott merged 1 commit into from
Jul 10, 2021
Merged

test: use common.PORT instead of hardcoded port number #39298

Trott merged 1 commit into from
Jul 10, 2021

Conversation

@Trott
Copy link
Member

@TrottTrott commented Jul 7, 2021

No description provided.

@github-actionsgithub-actionsbot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 7, 2021
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 8, 2021
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 8, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 8, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38895/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 8, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38899/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 8, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38901/

@Trott
Copy link
MemberAuthor

Trott commented Jul 10, 2021

Landed in debdc1d

@TrottTrott merged commit debdc1d into nodejs:masterJul 10, 2021
@TrottTrott deleted the speed branch July 10, 2021 00:03
targos pushed a commit that referenced this pull request Jul 11, 2021
@Trott@targos
test: use common.PORT instead of hardcoded port number
0ec93a1
PR-URL: #39298 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Jul 13, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@Trott@targos
test: use common.PORT instead of hardcoded port number
a45bf2f
PR-URL: #39298 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Sep 4, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@nodejs-github-bot@jasnell@cjihrig