stream: cleanup async handling#39329
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
ronag commented Jul 9, 2021
@nodejs/streams |
ronag added request-ci 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jul 9, 2021
ronagforce-pushed the stream-async branch 3 times, most recently from 495aa7a to 71a01e0Compare
jasnell approved these changes Jul 9, 2021
ronag added author ready github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jul 9, 2021
mcollina added dont-land-on-v12.x baking-for-lts Collaborator
nodejs-github-bot commented Jul 10, 2021
Collaborator
nodejs-github-bot commented Jul 10, 2021
Collaborator
nodejs-github-bot commented Jul 11, 2021
Collaborator
nodejs-github-bot commented Jul 11, 2021
Collaborator
nodejs-github-bot commented Jul 11, 2021
ronag added a commit that referenced this pull request Jul 11, 2021
Cleanup async stream method handling. PR-URL: #39329 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
MemberAuthor
ronag commented Jul 11, 2021
Landed in f2f6872 |
targos pushed a commit that referenced this pull request Jul 13, 2021
Cleanup async stream method handling. PR-URL: #39329 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Member
Flarna commented Jul 27, 2021
targos removed the baking-for-lts Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup async stream method handling. Removes duplicate code and unifies behavior.