lib: rename TransferedReadableStream etc.#39352
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added lib / src 
targos approved these changes Jul 11, 2021
ronag approved these changes Jul 11, 2021
lpinca approved these changes Jul 11, 2021
Contributor
Fast-track has been requested by @targos. Please 👍 to approve. |
Member
targos commented Jul 12, 2021
I'd like to fast-track to include in the next v16.x release (the first to include web streams) |
targos added request-ci 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Jul 12, 2021
Collaborator
jasnell approved these changes Jul 12, 2021
cjihrig approved these changes Jul 13, 2021
Member
targos commented Jul 13, 2021
Landed in 528639c |
targos pushed a commit that referenced this pull request Jul 13, 2021
PR-URL: #39352 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Jul 13, 2021
PR-URL: #39352 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
richardlau commented Jul 15, 2021
Blocked from 14.x as needs #39062 to land first. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does change some error messages, but, since it's an experimental module, that probably does not make it semver-major. I can move those changes to a separate PR if it is a concern.