Skip to content

[v14.x backport] src: use SPrintF in ProcessEmitWarning#39419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RaisinTen wants to merge 2 commits into from
Closed

[v14.x backport] src: use SPrintF in ProcessEmitWarning #39419

RaisinTen wants to merge 2 commits into from

Conversation

@RaisinTen
Copy link
Member

@RaisinTenRaisinTen commented Jul 17, 2021

PR-URL: #38758
Reviewed-By: James M Snell [email protected]
Reviewed-By: Joyee Cheung [email protected]
Reviewed-By: Anna Henningsen [email protected]

Original pull request: #38758

@github-actionsgithub-actionsbot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v14.x labels Jul 17, 2021
RaisinTen added a commit to RaisinTen/node that referenced this pull request Jul 17, 2021
@RaisinTen
src: use SPrintF in ProcessEmitWarning
9ce9b14
PR-URL: nodejs#38758 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Backport-PR-URL: nodejs#39419
@RaisinTenRaisinTenforce-pushed the backport-38758-to-v14.x branch from 4e0a336 to 9ce9b14CompareJuly 17, 2021 15:09
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTenRaisinTen mentioned this pull request Jul 17, 2021
Closed
@aduh95
Copy link
Contributor

aduh95 commented Jul 17, 2021

You probably need to backport #39091 alongside it.

@RaisinTen
Copy link
MemberAuthor

RaisinTen commented Jul 17, 2021

You probably need to backport #39091 alongside it.

@aduh95 Is there an example PR which backports multiple PRs?
Also, I tried to locally land it and it lands cleanly, so I'm not sure if I'm supposed to backport it myself.

@aduh95
Copy link
Contributor

aduh95 commented Jul 17, 2021•
edited
Loading

You can use the following commands:

git reset 9ce9b14729788cfa2666117e3ab940cc4ad05307 --hard git cherry-pick 19b80cc4ece088c0b02e556e217481b3ade744ff git push origin HEAD:backport-38758-to-v14.x

Also, I tried to locally land it and it lands cleanly, so I'm not sure if I'm supposed to backport it myself.

I think it makes no sense to backport one without the other, so I'd say that yes, you are supposed to include both in this PR.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen
Copy link
MemberAuthor

RaisinTen commented Jul 18, 2021

@aduh95 Thanks, done! PTAL.

@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 18, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 18, 2021•
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/39105/ 💚

RaisinTenand others added 2 commits July 19, 2021 16:12
@RaisinTen@richardlau
src: use SPrintF in ProcessEmitWarning
50afb5a
PR-URL: nodejs#38758 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Backport-PR-URL: nodejs#39419
@mmomtchev@richardlau
build: fix building with external builtins
86ab15d
PR-URL: nodejs#39091Fixes: nodejs#39090 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@richardlaurichardlauforce-pushed the backport-38758-to-v14.x branch from e91b66f to 86ab15dCompareJuly 19, 2021 20:23
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 19, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39143/

richardlau pushed a commit that referenced this pull request Jul 19, 2021
@RaisinTen@richardlau
src: use SPrintF in ProcessEmitWarning
b0ef28a
PR-URL: #38758 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Backport-PR-URL: #39419
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@mmomtchev@richardlau
build: fix building with external builtins
5f7c331
PR-URL: #39091 Backport-PR-URL: #39419Fixes: #39090 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@richardlau
Copy link
Member

richardlau commented Jul 19, 2021

Landed in 90fae0f...5f7c331

richardlau pushed a commit that referenced this pull request Jul 20, 2021
@RaisinTen@richardlau
src: use SPrintF in ProcessEmitWarning
e7f266e
PR-URL: #38758 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Backport-PR-URL: #39419
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@mmomtchev@richardlau
build: fix building with external builtins
1ab4f81
PR-URL: #39091 Backport-PR-URL: #39419Fixes: #39090 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@RaisinTenRaisinTen deleted the backport-38758-to-v14.x branch July 21, 2021 09:18
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@RaisinTen@foxxyz
src: use SPrintF in ProcessEmitWarning
221e75b
PR-URL: nodejs#38758 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Backport-PR-URL: nodejs#39419
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@mmomtchev@foxxyz
build: fix building with external builtins
72c0c71
PR-URL: nodejs#39091 Backport-PR-URL: nodejs#39419Fixes: nodejs#39090 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes

@richardlaurichardlaurichardlau approved these changes

@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RaisinTen@nodejs-github-bot@aduh95@richardlau@targos@mmomtchev