net: small code cleanup#3943
Closed
net: small code cleanup #3943
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`options` is already a param of the function.
Contributor
cjihrig commented Nov 20, 2015
LGTM. This is likely left over from when |
Contributor
evanlucas commented Nov 20, 2015
LGTM |
1 similar comment
Member
targos commented Nov 20, 2015
LGTM |
Contributor
evanlucas commented Nov 20, 2015
Contributor
MylesBorins commented Nov 20, 2015
LGTM |
jasnell pushed a commit that referenced this pull request Nov 20, 2015
`options` is already a param of the function. PR-URL: #3943 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
jasnell commented Nov 20, 2015
Landed in 9472a0c |
rvagg pushed a commit that referenced this pull request Dec 5, 2015
`options` is already a param of the function. PR-URL: #3943 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Dec 8, 2015
Closed
MylesBorins pushed a commit that referenced this pull request Dec 29, 2015
`options` is already a param of the function. PR-URL: #3943 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
`options` is already a param of the function. PR-URL: #3943 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optionsis already a param of the function.