benchmark: add constant declarations for net#3950
Closed
+5 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JungMinu changed the title net constantnetJungMinu changed the title netnetJungMinu changed the title netnet
Contributor
tflanagan commented Nov 21, 2015
Could you fix the |
Member
targos commented Nov 21, 2015
Can you add a |
MemberAuthor
JungMinu commented Nov 21, 2015
@tflanagan@targos Sure, will do :) |
Constant declaration for `net` is omitted in `idle_server.js` Add a constant declaration for constant `net` benchmark: add constant declarations for `net`
MemberAuthor
JungMinu commented Nov 21, 2015
finished and rebased, Thanks :) |
JungMinu changed the title netnet
Contributor
silverwind commented Jan 27, 2016
LGTM if you still want to land this. We should eventually include benchmark in ESLint. |
Member
jasnell commented Jan 29, 2016
LGTM |
JungMinu added a commit that referenced this pull request Jan 29, 2016
Constant declaration for `net` is omitted in `idle_server.js` Add a constant declaration for constant `net` PR-URL: #3950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MemberAuthor
JungMinu commented Jan 29, 2016
Thanks, landed in 4126441 |
rvagg pushed a commit that referenced this pull request Feb 8, 2016
Constant declaration for `net` is omitted in `idle_server.js` Add a constant declaration for constant `net` PR-URL: #3950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
Constant declaration for `net` is omitted in `idle_server.js` Add a constant declaration for constant `net` PR-URL: #3950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
Constant declaration for `net` is omitted in `idle_server.js` Add a constant declaration for constant `net` PR-URL: #3950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
Constant declaration for `net` is omitted in `idle_server.js` Add a constant declaration for constant `net` PR-URL: #3950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Constant declaration for `net` is omitted in `idle_server.js` Add a constant declaration for constant `net` PR-URL: nodejs#3950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constant declaration for
netis omitted inidle_server.jsAdd a constant declaration for constant
net