Fix test-cluster-worker-isdead#3954
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
santigimenoforce-pushed the fix_worker_isdead branch from 560adf7 to a4167e5Compare
Member
JungMinu commented Nov 21, 2015
would you please squash the commits? |
Check if the worker 'isDead' instead of 'isConnected' as the 'disconnect' event is not guaranteed to be received before the 'exit' event. Remove the 'net' dependency as it is not used.
santigimenoforce-pushed the fix_worker_isdead branch from a4167e5 to a3ffac7Compare
MemberAuthor
santigimeno commented Nov 21, 2015
Done |
Member
targos commented Nov 21, 2015
Member
JungMinu commented Nov 21, 2015
CI is not green with |
This was referenced Nov 21, 2015
Contributor
Fishrock123 commented Nov 21, 2015
Better flakiness stress-test: https://ci.nodejs.org/job/node-stress-single-test/25/ Trying on |
Member
JungMinu commented Nov 21, 2015
@Fishrock123 CI is happy with new stress-test, LGTM |
Contributor
cjihrig commented Nov 23, 2015
The change LGTM, but I wonder why |
Contributor
cjihrig commented Nov 23, 2015
Actually the flakiness is probably due the inability to determine the order between the |
Member
JungMinu commented Dec 5, 2015
@cjihrig@Fishrock123 May I land this? Thank you |
Contributor
cjihrig commented Dec 5, 2015
@JungMinu yes, this should be good to go. |
JungMinu pushed a commit that referenced this pull request Dec 5, 2015
Check if the worker 'isDead' instead of 'isConnected' as the 'disconnect' event is not guaranteed to be received before the 'exit' event. Remove the 'net' dependency as it is not used. PR-URL: #3954 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Member
JungMinu commented Dec 5, 2015
Thanks, landed in f8cf947 |
rvagg pushed a commit that referenced this pull request Dec 8, 2015
Check if the worker 'isDead' instead of 'isConnected' as the 'disconnect' event is not guaranteed to be received before the 'exit' event. Remove the 'net' dependency as it is not used. PR-URL: #3954 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
This was referenced Dec 8, 2015
MylesBorins pushed a commit that referenced this pull request Dec 15, 2015
Check if the worker 'isDead' instead of 'isConnected' as the 'disconnect' event is not guaranteed to be received before the 'exit' event. Remove the 'net' dependency as it is not used. PR-URL: #3954 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Closed
jasnell pushed a commit that referenced this pull request Dec 17, 2015
Check if the worker 'isDead' instead of 'isConnected' as the 'disconnect' event is not guaranteed to be received before the 'exit' event. Remove the 'net' dependency as it is not used. PR-URL: #3954 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
jasnell pushed a commit that referenced this pull request Dec 23, 2015
Check if the worker 'isDead' instead of 'isConnected' as the 'disconnect' event is not guaranteed to be received before the 'exit' event. Remove the 'net' dependency as it is not used. PR-URL: #3954 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Check if the worker 'isDead' instead of 'isConnected' as the 'disconnect' event is not guaranteed to be received before the 'exit' event. Remove the 'net' dependency as it is not used. PR-URL: nodejs#3954 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It tries to fix#3886