Skip to content

Conversation

@Trott
Copy link
Member

This is dependent on #3941 being landed first.

Tests on SmartOS are sometimes retried due to a SmartOS issue on CI.
When this happens, a TAP diagnostic message is written.

R=@indutny

@TrottTrott added the test Issues and PRs related to the tests. label Nov 21, 2015
@Trott
Copy link
MemberAuthor

@mscdexmscdex added the tools Issues and PRs related to the tools directory. label Nov 21, 2015
@indutny
Copy link
Member

Fantastic! LGTM

@Trott
Copy link
MemberAuthor

TL;DR: Ran a few tests to make sure it works as advertised on SmartOS with ECONNREFUSED errors and it looks good.

I doctored up a test that would always fail with ECONNREFUSED and ran it through CI. Here's what it looks like:

not ok 209 test-econnrefused.js # ECONNREFUSED received, test retried # events.js:142 # throw er; // Unhandled 'error' event # ^ # # Error: connect ECONNREFUSED 127.0.0.1:12346 # at Object.exports._errnoException (util.js:873:11) # at exports._exceptionWithHostPort (util.js:896:20) # at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1066:14) --- duration_ms: 0.549 

See https://ci.nodejs.org/job/node-test-commit-smartos/404/nodes=smartos14-64/console for the full console log.

Then I made it so it would fail with ECONNREFUSED the first time it ran but succeed the second time it ran. Here's what that looks like:

ok 209 test-econnrefused.js # ECONNREFUSED received, test retried --- duration_ms: 0.548 

For the full console log on that one: https://ci.nodejs.org/job/node-test-commit-smartos/406/nodes=smartos14-64/console

@indutny
Copy link
Member

Still LGTM ;)

@TrottTrottforce-pushed the log-retries branch 2 times, most recently from 326fce3 to f9501f6CompareNovember 24, 2015 15:55
@Trott
Copy link
MemberAuthor

One last post-rebase CI: https://ci.nodejs.org/job/node-test-commit/1233/

Tests on SmartOS are sometimes retried due to a SmartOS issue on CI. When this happens, a TAP diagnostic message is written. PR-URL: nodejs#3960 Reviewed-By: Fedor Indutny <[email protected]>
@Trott
Copy link
MemberAuthor

CI failures on arm-fanned and smartos but they both look Jenkins-related and not actual test failures. /cc @nodejs/build

Failures on windows-fanned look unrelated too. I'll confirm previous failures for those two tests and get them added to the flaky test list. :-/

@Trott
Copy link
MemberAuthor

Landed in 41519fd

@TrottTrott closed this Nov 24, 2015
@TrottTrott merged commit 41519fd into nodejs:masterNov 24, 2015
Trott added a commit that referenced this pull request Dec 5, 2015
Tests on SmartOS are sometimes retried due to a SmartOS issue on CI. When this happens, a TAP diagnostic message is written. PR-URL: #3960 Reviewed-By: Fedor Indutny <[email protected]>
@rvaggrvagg mentioned this pull request Dec 17, 2015
Trott added a commit that referenced this pull request Dec 29, 2015
Tests on SmartOS are sometimes retried due to a SmartOS issue on CI. When this happens, a TAP diagnostic message is written. PR-URL: #3960 Reviewed-By: Fedor Indutny <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Tests on SmartOS are sometimes retried due to a SmartOS issue on CI. When this happens, a TAP diagnostic message is written. PR-URL: #3960 Reviewed-By: Fedor Indutny <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jan 19, 2016
@TrottTrott deleted the log-retries branch January 13, 2022 22:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testIssues and PRs related to the tests.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@indutny@mscdex@jasnell@MylesBorins