Skip to content

Conversation

@Trott
Copy link
Member

The test did not fail after 9999 runs in continuous integration. https://ci.nodejs.org/job/node-stress-single-test/28/nodes=armv7-wheezy/console

Remove it's flaky status.

Fixes: #2557

@cjihrig
Copy link
Contributor

LGTM

@TrottTrott added test Issues and PRs related to the tests. arm Issues and PRs related to the ARM platform. labels Nov 23, 2015
@mscdexmscdex added the cluster Issues and PRs related to the cluster subsystem. label Nov 23, 2015
@bnoordhuis
Copy link
Member

Another LGTM.

@r-52
Copy link
Contributor

r-52 commented Nov 23, 2015

LGTM

@rvagg
Copy link
Member

lgtm, for good measure

The test did not fail after 9999 runs in continuous integration. Remove it's flaky status. Fixes: nodejs#2557
Trott added a commit that referenced this pull request Nov 24, 2015
The test did not fail after 9999 runs in continuous integration. Remove it's flaky status. Fixes: #2557 PR-URL: #3975 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
@r-52
Copy link
Contributor

r-52 commented Nov 24, 2015

Thanks @Trott ! Landed in 6588422

@r-52r-52 closed this Nov 24, 2015
Trott added a commit that referenced this pull request Dec 1, 2015
The test did not fail after 9999 runs in continuous integration. Remove it's flaky status. Fixes: #2557 PR-URL: #3975 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Trott added a commit that referenced this pull request Dec 4, 2015
The test did not fail after 9999 runs in continuous integration. Remove it's flaky status. Fixes: #2557 PR-URL: #3975 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Trott added a commit that referenced this pull request Dec 5, 2015
The test did not fail after 9999 runs in continuous integration. Remove it's flaky status. Fixes: #2557 PR-URL: #3975 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
@jasnelljasnell mentioned this pull request Dec 17, 2015
Trott added a commit that referenced this pull request Dec 17, 2015
The test did not fail after 9999 runs in continuous integration. Remove it's flaky status. Fixes: #2557 PR-URL: #3975 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
Trott added a commit that referenced this pull request Dec 23, 2015
The test did not fail after 9999 runs in continuous integration. Remove it's flaky status. Fixes: #2557 PR-URL: #3975 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Klauke <[email protected]>
@TrottTrott deleted the cluster-flaky branch January 13, 2022 22:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

armIssues and PRs related to the ARM platform.clusterIssues and PRs related to the cluster subsystem.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@Trott@cjihrig@bnoordhuis@r-52@rvagg@mscdex@jasnell@MylesBorins