tools: add support for import assertions in linter#39924
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasnell approved these changes Aug 28, 2021
aduh95 added the author ready 
bmeck approved these changes Aug 28, 2021
watilde approved these changes Aug 31, 2021
Lxxyx approved these changes Aug 31, 2021
Member
jasnell commented Sep 3, 2021
Landed in f26c2ce |
jasnell pushed a commit that referenced this pull request Sep 3, 2021
PR-URL: #39924 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
targos pushed a commit that referenced this pull request Sep 4, 2021
PR-URL: #39924 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
targos pushed a commit that referenced this pull request Sep 6, 2021
PR-URL: #39924 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
targos pushed a commit that referenced this pull request Sep 6, 2021
PR-URL: #39924 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
PR-URL: nodejs#39924 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
ContributorAuthor
aduh95 commented Oct 14, 2021
This was (erroneously I think) removed in #40394, re-opening. |
aduh95force-pushed the import-assertions-linter branch from f6e527b to 2cbfc9fCompare
Member
targos commented Oct 14, 2021
It seems like you're right, but if nothing breaks when we remove it, doesn't it prove that we don't need it (yet) ? |
ContributorAuthor
aduh95 commented Oct 14, 2021
Fair, added a test. |
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Oct 14, 2021
targos approved these changes Oct 14, 2021
GeoffreyBooth approved these changes Oct 14, 2021
Member
GeoffreyBooth left a comment
GeoffreyBooth left a comment There was a problem hiding this comment.
We need this in order to land #40250.
Collaborator
nodejs-github-bot commented Oct 14, 2021
23 tasks
Collaborator
nodejs-github-bot commented Oct 15, 2021
Collaborator
nodejs-github-bot commented Oct 15, 2021
Collaborator
nodejs-github-bot commented Oct 15, 2021
Collaborator
nodejs-github-bot commented Oct 15, 2021
Collaborator
nodejs-github-bot commented Oct 15, 2021
This was referenced Oct 16, 2021
Collaborator
nodejs-github-bot commented Oct 17, 2021
aduh95 added the commit-queue github-actionsbot removed the commit-queue 
Contributor
Landed in cbc7b5d...f5e9486 |
nodejs-github-bot pushed a commit that referenced this pull request Oct 17, 2021
PR-URL: #39924 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
This was referenced Oct 18, 2021
targos pushed a commit that referenced this pull request Nov 4, 2021
PR-URL: #39924 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Necessary for #39921.