crypto: fix RSA-PSS default saltLength#39999
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
jasnell approved these changes Sep 5, 2021
Member
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
+1 to treating this as a bug fix
cjihrig approved these changes Sep 5, 2021
panva approved these changes Sep 5, 2021
Collaborator
nodejs-github-bot commented Sep 5, 2021
panva added author ready Collaborator
nodejs-github-bot commented Sep 6, 2021
Collaborator
nodejs-github-bot commented Sep 7, 2021
Member
panva commented Sep 7, 2021
tniessen added a commit to tniessen/node that referenced this pull request Sep 7, 2021
MemberAuthor
tniessen commented Sep 7, 2021
panva pushed a commit that referenced this pull request Sep 9, 2021
Refs: #39999 PR-URL: #40031 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Collaborator
nodejs-github-bot commented Sep 9, 2021
tniessenforce-pushed the crypto-fix-rsa-pss-keygen-default-saltlength branch from d6dbc3c to db358bfCompareCollaborator
nodejs-github-bot commented Sep 9, 2021
Collaborator
nodejs-github-bot commented Sep 9, 2021
Member
panva commented Sep 9, 2021
Landed in a42bd7e |
panva pushed a commit that referenced this pull request Sep 9, 2021
PR-URL: #39999 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
MemberAuthor
tniessen commented Sep 10, 2021
Thanks for reviewing everyone. |
This was referenced Sep 14, 2021
This was referenced Sep 16, 2021
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
Refs: #39999 PR-URL: #40031 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
PR-URL: #39999 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on my understanding of RFC 8017, when
hashAlgorithmis set butsaltLengthis not, the value ofsaltLengthassociated with the key pair should default to the digest size ofhashAlgorithm, not to0.I am not sure why OpenSSL uses
0. I suspect it is because we don't callEVP_PKEY_CTX_set_rsa_pss_keygen_saltlenand0is the least restrictive value, at least within OpenSSL. This behavior can still be restored by explicitly settingsaltLengthto0.I'd argue that this is a bug fix. If we are concerned about semverity, I could modify this PR to only affect the new options (#39927) and keep the behavior of the old options intact. Personally, I don't think it's necessary to go that route.