deps: V8: cherry-pick 9a607043cb31#40046
Closed
+3 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original commit message: [compiler] Gracefully handle an unsupported situation ... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <[email protected]> Commit-Queue: Jakob Gruber <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Cr-Commit-Position: refs/heads/main@{#76741} Refs: v8/v8@9a60704
nodejs-github-bot added build 
This comment has been minimized.
This comment has been minimized.
gengjiawen added request-ci 
Contributor
Fast-track has been requested by @gengjiawen. Please 👍 to approve. |
targos approved these changes Sep 9, 2021
Member
|
github-actionsbot removed the request-ci 
Collaborator
Collaborator
rvsia added a commit to rvsia/sources-ui that referenced this pull request Sep 9, 2021
- until nodejs/node#40046 is merged
gengjiawen added the commit-queue github-actionsbot removed the commit-queue Contributor
Commit Queue failed- Loading data for nodejs/node/pull/40046 ✔ Done loading data for nodejs/node/pull/40046 ----------------------------------- PR info ------------------------------------ Title deps: V8: cherry-pick 9a607043cb31 (#40046) Author Jiawen Geng (@gengjiawen) Branch gengjiawen:patch_v8 -> nodejs:master Labels build, v8 engine, fast-track, needs-ci Commits 1 - deps: V8: cherry-pick 9a607043cb31 Committers 1 - Jiawen Geng PR-URL: https://github.com/nodejs/node/pull/40046 Fixes: https://github.com/nodejs/node/issues/40030 Refs: https://github.com/v8/v8/commit/9a607043cb3161f8ceae1583807bece595388108 Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40046 Fixes: https://github.com/nodejs/node/issues/40030 Refs: https://github.com/v8/v8/commit/9a607043cb3161f8ceae1583807bece595388108 Reviewed-By: Michaël Zasso -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 09 Sep 2021 06:40:00 GMT ✔ Approvals: 1 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40046#pullrequestreview-749930279 ℹ This PR is being fast-tracked ✖ This PR needs to wait 162 more hours to land (or 42 hours if there is one more approval) ✔ Last GitHub Actions successful ℹ Last V8 CI on 2021-09-09T06:46:51Z: https://ci.nodejs.org/job/node-test-commit-v8-linux/4260/ ℹ Last Full PR CI on 2021-09-09T08:34:23Z: https://ci.nodejs.org/job/node-test-pull-request/39876/ - Querying data for job/node-test-pull-request/39876/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1217149145 |
github-actionsbot added the commit-queue-failed 
richardlau approved these changes Sep 9, 2021
richardlau added commit-queue github-actionsbot removed the commit-queue Contributor
Landed in 513a979...be3af51 |
nodejs-github-bot pushed a commit that referenced this pull request Sep 9, 2021
Original commit message: [compiler] Gracefully handle an unsupported situation ... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <[email protected]> Commit-Queue: Jakob Gruber <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Cr-Commit-Position: refs/heads/main@{#76741} Refs: v8/v8@9a60704 PR-URL: #40046Fixes: #40030 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 10, 2021
Original commit message: [compiler] Gracefully handle an unsupported situation ... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <[email protected]> Commit-Queue: Jakob Gruber <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Cr-Commit-Position: refs/heads/main@{#76741} Refs: v8/v8@9a60704 PR-URL: #40046Fixes: #40030 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
3 tasks
This was referenced Sep 14, 2021
targos pushed a commit to targos/node that referenced this pull request Sep 17, 2021
Original commit message: [compiler] Gracefully handle an unsupported situation ... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <[email protected]> Commit-Queue: Jakob Gruber <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Cr-Commit-Position: refs/heads/main@{#76741} Refs: v8/v8@9a60704 PR-URL: nodejs#40046Fixes: nodejs#40030 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Sep 29, 2021
Original commit message: [compiler] Gracefully handle an unsupported situation ... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <[email protected]> Commit-Queue: Jakob Gruber <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Cr-Commit-Position: refs/heads/main@{#76741} Refs: v8/v8@9a60704 PR-URL: nodejs#40046Fixes: nodejs#40030 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Oct 1, 2021
Original commit message: [compiler] Gracefully handle an unsupported situation ... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <[email protected]> Commit-Queue: Jakob Gruber <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Cr-Commit-Position: refs/heads/main@{#76741} Refs: v8/v8@9a60704 PR-URL: nodejs#40046Fixes: nodejs#40030 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this pull request Oct 2, 2021
Original commit message: [compiler] Gracefully handle an unsupported situation ... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <[email protected]> Commit-Queue: Jakob Gruber <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Cr-Commit-Position: refs/heads/main@{#76741} Refs: v8/v8@9a60704 PR-URL: #40046Fixes: #40030 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Oct 2, 2021
Original commit message: [compiler] Gracefully handle an unsupported situation ... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <[email protected]> Commit-Queue: Jakob Gruber <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Cr-Commit-Position: refs/heads/main@{#76741} Refs: v8/v8@9a60704 PR-URL: nodejs#40046Fixes: nodejs#40030 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Oct 4, 2021
Original commit message: [compiler] Gracefully handle an unsupported situation ... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <[email protected]> Commit-Queue: Jakob Gruber <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Cr-Commit-Position: refs/heads/main@{#76741} Refs: v8/v8@9a60704 PR-URL: nodejs#40046Fixes: nodejs#40030 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #40030
Original commit message:
Refs: v8/v8@9a60704