Skip to content

Conversation

@Trott
Copy link
Member

See #3957 for details and examples
failures.

Ref: #3957

@Trott
Copy link
MemberAuthor

@mscdexmscdex added cluster Issues and PRs related to the cluster subsystem. windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. labels Nov 24, 2015
@bnoordhuis
Copy link
Member

LGTM although I'd like it if we understood better why the test is so flaky on Windows.

Trott added a commit to Trott/io.js that referenced this pull request Nov 25, 2015
See nodejs#3957 for details and examples failures. Ref: nodejs#3957 Reviewed-By: Ben Noordhuis <[email protected]> PR-URL: nodejs#4006
@Trott
Copy link
MemberAuthor

Landed in 16db4c4

@TrottTrott closed this Nov 25, 2015
Trott added a commit that referenced this pull request Dec 1, 2015
See #3957 for details and examples failures. Ref: #3957 Reviewed-By: Ben Noordhuis <[email protected]> PR-URL: #4006
Trott added a commit that referenced this pull request Dec 4, 2015
See #3957 for details and examples failures. Ref: #3957 Reviewed-By: Ben Noordhuis <[email protected]> PR-URL: #4006
Trott added a commit that referenced this pull request Dec 5, 2015
See #3957 for details and examples failures. Ref: #3957 Reviewed-By: Ben Noordhuis <[email protected]> PR-URL: #4006
@jasnelljasnell mentioned this pull request Dec 17, 2015
Trott added a commit that referenced this pull request Dec 17, 2015
See #3957 for details and examples failures. Ref: #3957 Reviewed-By: Ben Noordhuis <[email protected]> PR-URL: #4006
Trott added a commit that referenced this pull request Dec 23, 2015
See #3957 for details and examples failures. Ref: #3957 Reviewed-By: Ben Noordhuis <[email protected]> PR-URL: #4006
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
See nodejs#3957 for details and examples failures. Ref: nodejs#3957 Reviewed-By: Ben Noordhuis <[email protected]> PR-URL: nodejs#4006
@TrottTrott deleted the send-flaky branch January 13, 2022 22:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clusterIssues and PRs related to the cluster subsystem.testIssues and PRs related to the tests.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@bnoordhuis@mscdex@jasnell@MylesBorins