Skip to content

[14.x backport] src: add option to disable loading native addons#40094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
d3lm wants to merge 1 commit into from
Closed

[14.x backport] src: add option to disable loading native addons #40094

d3lm wants to merge 1 commit into from

Conversation

@d3lm
Copy link
Contributor

@d3lmd3lm commented Sep 13, 2021

Backport for #39977 of Node.js 14.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v14.x labels Sep 13, 2021
@d3lmd3lmforce-pushed the backport/14.x/no-addons branch from eba2cf3 to b56acc1CompareSeptember 13, 2021 08:26
@d3lmd3lm changed the title [14.x backport] feat: add option to disable loading native addons[14.x backport] src: add option to disable loading native addonsSep 13, 2021
@addaleaxaddaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 13, 2021
@d3lmd3lmforce-pushed the backport/14.x/no-addons branch from b56acc1 to 9e7b1bbCompareSeptember 13, 2021 08:52
@bmeck
Copy link
Member

bmeck commented Sep 13, 2021

cc @nodejs/backporters

bmeck
bmeck approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@bmeckbmeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MesteeryMesteery added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Oct 12, 2021
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 12, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40258/

This was referenced Oct 13, 2021
Open
Open
@d3lm
Copy link
ContributorAuthor

d3lm commented Oct 14, 2021

Pinging @nodejs/backporters again. Is there something I can do? When can we expect this to be backported?

@targos
Copy link
Member

targos commented Oct 14, 2021

There's nothing more to do. The releaser who's going to prepare the next semver-minor release will merge the PR when it happens.

@guybedfordguybedford added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 14, 2021
This was referenced Oct 15, 2021
Open
Open
Open
Open
Open
@d3lm
Copy link
ContributorAuthor

d3lm commented Nov 12, 2021

Any news? When does this get backported? The PR has been released for a while now.

@d3lm
Copy link
ContributorAuthor

d3lm commented Dec 1, 2021

When can I expect this to be backported? It's been a few weeks now since the original PR landed in 16.

@mhdawson
Copy link
Member

mhdawson commented Dec 3, 2021

You can look at the planned releases for 16.x here - nodejs/Release#658

@mhdawson
Copy link
Member

mhdawson commented Dec 3, 2021

Oops should have pointed to the schedule for 14.x which is here - nodejs/Release#567

@d3lm
Copy link
ContributorAuthor

d3lm commented Dec 3, 2021

@mhdawson Thanks!

@d3lm
Copy link
ContributorAuthor

d3lm commented Jan 4, 2022

Hey, just checking in again on this PR. It's been 3 month almost since this PR has been created and the original PR has been merged and released. When will this be backported to 14.x?

@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 18, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/41986/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 18, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/42006/

@d3lm
Copy link
ContributorAuthor

d3lm commented Jan 23, 2022

CI seems to be good on this one. Any updates?

richardlau pushed a commit that referenced this pull request Jan 25, 2022
@d3lm@richardlau
src: add option to disable loading native addons
b050c65
Backport-PR-URL: #40094 PR-URL: #39977 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@richardlau
Copy link
Member

richardlau commented Jan 25, 2022

Landed in b050c65.

CI seems to be good on this one. Any updates?

I'll aim to get this into Node.js 14.19.0 (which I'm putting together now).

@d3lm
Copy link
ContributorAuthor

d3lm commented Jan 25, 2022

@richardlau Thanks so much 🙏

@d3lmd3lm deleted the backport/14.x/no-addons branch January 25, 2022 21:59
@d3lm
Copy link
ContributorAuthor

d3lm commented Jan 28, 2022

@richardlau Any rough estimate on when to expect 14.19?

@targos
Copy link
Member

targos commented Jan 28, 2022

@d3lm#41696

@d3lm
Copy link
ContributorAuthor

d3lm commented Jan 28, 2022

Thanks @targos 🙏

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guybedfordguybedfordguybedford approved these changes

+1 more reviewer

@bmeckbmeckbmeck approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@d3lm@bmeck@nodejs-github-bot@targos@mhdawson@richardlau@guybedford@addaleax@Mesteery