src,crypto: remove AllocatedBuffer from crypto_cipher.cc#40400
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
This comment has been minimized.
This comment has been minimized.
19 tasks
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Darshan Sen <[email protected]>
RaisinTenforce-pushed the src,crypto/remove-AllocatedBuffer-from-crypto_cipher.cc branch from 9841890 to 869adb8Compare
addaleax approved these changes Oct 11, 2021
22 tasks
This comment has been minimized.
This comment has been minimized.
RaisinTen added author ready This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented Oct 13, 2021
This was referenced Oct 14, 2021
Ayase-252 added the commit-queue 
github-actionsbot removed the commit-queue 
Contributor
Landed in aef8abb...e1d598c |
nodejs-github-bot pushed a commit that referenced this pull request Oct 20, 2021
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #40400 Reviewed-By: Anna Henningsen <[email protected]>
RaisinTen deleted the src,crypto/remove-AllocatedBuffer-from-crypto_cipher.cc branch targos pushed a commit that referenced this pull request Oct 23, 2021
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #40400 Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Nov 23, 2021
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #40400 Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darshan Sen [email protected]