src,crypto: use std::variant in DH params#40457
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Darshan Sen <[email protected]>
RaisinTenforce-pushed the src,crypto/use-std-variant-in-DH-params branch from 869f42a to 29a2559Compare This comment has been minimized.
This comment has been minimized.
addaleax approved these changes Oct 14, 2021
Member
richardlau commented Oct 14, 2021
Added dont-land- labels as |
RaisinTen added the author ready 
richardlau approved these changes Oct 14, 2021
tniessen approved these changes Oct 14, 2021
23 tasks
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 16, 2021
Collaborator
nodejs-github-bot commented Oct 17, 2021
This was referenced Oct 18, 2021
RaisinTen added the commit-queue 
github-actionsbot removed the commit-queue 
Contributor
Landed in 68dc180...5c7af3f |
nodejs-github-bot pushed a commit that referenced this pull request Oct 22, 2021
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #40457 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
31 tasks
targos pushed a commit that referenced this pull request Oct 23, 2021
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #40457 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darshan Sen [email protected]