Skip to content

policy: fix message for invalid manifest specifier#40574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Trott merged 1 commit into from
Oct 25, 2021
Merged

policy: fix message for invalid manifest specifier #40574

Trott merged 1 commit into from
Oct 25, 2021

Conversation

@Trott
Copy link
Member

@TrottTrott commented Oct 23, 2021

Add test for invalid manifest specifier and fix the error message
which is missing a space ("singletrailing" instead of
"single trailing").

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. policy Issues and PRs related to the policy subsystem. labels Oct 23, 2021
@TrottTrott requested a review from bmeckOctober 23, 2021 05:42
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2021
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2021
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 23, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 23, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40420/

@MesteeryMesteery removed the needs-ci PRs that need a full CI run. label Oct 23, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 23, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40423/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 23, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40427/

@github-actionsgithub-actionsbot mentioned this pull request Oct 24, 2021
Open
31 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 24, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40438/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 24, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40440/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 24, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40444/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 24, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40446/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 24, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40449/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 24, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40451/

@github-actionsgithub-actionsbot mentioned this pull request Oct 25, 2021
Open
24 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 25, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40456/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 25, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40457/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 25, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40458/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 25, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40459/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 25, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40460/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 25, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40463/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 25, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40465/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 25, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40467/

@Trott
policy: fix message for invalid manifest specifier
070b54a
Add test for invalid manifest specifier and fix the error message which is missing a space ("singletrailing" instead of "single trailing"). PR-URL: nodejs#40574 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Voltrex <[email protected]>
@Trott
Copy link
MemberAuthor

Trott commented Oct 25, 2021

Landed in 070b54a

@TrottTrott merged commit 070b54a into nodejs:masterOct 25, 2021
@TrottTrott deleted the manifest-fix branch October 25, 2021 05:42
This was referenced Oct 26, 2021
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 6, 2021
@Trott@targos
policy: fix message for invalid manifest specifier
b320387
Add test for invalid manifest specifier and fix the error message which is missing a space ("singletrailing" instead of "single trailing"). PR-URL: #40574 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Voltrex <[email protected]>
@targostargos mentioned this pull request Nov 8, 2021
Merged
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
@Trott@BethGriggs
policy: fix message for invalid manifest specifier
dab574e
Add test for invalid manifest specifier and fix the error message which is missing a space ("singletrailing" instead of "single trailing"). PR-URL: #40574 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Voltrex <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@LxxyxLxxyxLxxyx approved these changes

@aduh95aduh95aduh95 approved these changes

@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes

+1 more reviewer

@bmeckbmeckbmeck approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.policyIssues and PRs related to the policy subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@Trott@nodejs-github-bot@bmeck@jasnell@lpinca@cjihrig@Lxxyx@aduh95@VoltrexKeyva@Mesteery