deps: upgrade npm to 8.1.3#40726
Closed
deps: upgrade npm to 8.1.3 #40726
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added dont-land-on-v12.x fast-track 
Contributor
Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve. |
Contributor
wraithgar commented Nov 4, 2021
An explanation for the size of the diff: there was a refactoring of some of the internals of the npm commands that resulted in a lot of churn for both the tests and the files. |
tniessen approved these changes Nov 4, 2021
cjihrig approved these changes Nov 4, 2021
VoltrexKeyva approved these changes Nov 4, 2021
github-actionsbot removed the request-ci 
This comment has been minimized.
This comment has been minimized.
lpinca approved these changes Nov 5, 2021
This comment has been minimized.
This comment has been minimized.
This was referenced Nov 6, 2021
This comment has been minimized.
This comment has been minimized.
46 tasks
This comment has been minimized.
This comment has been minimized.
Collaborator
nodejs-github-bot commented Nov 8, 2021
23 tasks
Member
Trott commented Nov 9, 2021
Can someone at @nodejs/npm rebase against master and force push to the PR branch? |
26 tasks
Contributor
wraithgar commented Nov 10, 2021
Done, thanks for the heads up. Our fork got a little behind there, it's up to date now. |
Trott added a commit to Trott/io.js that referenced this pull request Nov 10, 2021
A somewhat old PR landed and it fails current linting. This is the fix. Ref: nodejs#40726
Member
Trott commented Nov 10, 2021
Argh...sorry, you'll need to do it one more time once #40781 lands. (Collaborators, please review and fast-track that. Thanks.) |
Contributor
wraithgar commented Nov 10, 2021
Ok I'm watching #40780 and will rebase our fork once that lands |
Member
Trott commented Nov 10, 2021
Sorry to do this to you, but a lint fix just landed. Can you rebase one more time? |
Contributor
wraithgar commented Nov 10, 2021
Done. this is really no problem at all, glad to help. |
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Nov 10, 2021
31 tasks
Trott approved these changes Nov 11, 2021
Member
Trott commented Nov 11, 2021
Landed in 6e16297 |
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 11, 2021
PR-URL: nodejs#40726 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Voltrex <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This was referenced Nov 12, 2021
targos pushed a commit that referenced this pull request Nov 21, 2021
PR-URL: #40726 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Voltrex <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
PR-URL: #40726 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Voltrex <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
PR-URL: #40726 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Voltrex <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v8.1.3 (2021-11-04)
BUG FIXES
8ffeb71df#3959 fix: refactor commands (@wraithgar)e5bfdaca4#3978 fix: shrinkwrap setting incorrect lockfileVersion (@lukekarrys)32ccd3c27#3988 fix: remove usage of unnecessary util.promisify (@lukekarrys)1e9c31c4e#3994 fix: npm help on windows (@wraithgar)22230ef3d#3987 fix: make prefixed usage errors more consistent (@lukekarrys)DEPENDENCIES
ac2fabb86#3990@npmcli/[email protected]a0d35ff20#3996@npmcli/[email protected]: