Skip to content

Conversation

@ronag
Copy link
Member

@ronagronag commented Nov 13, 2021

Fixes: #40800

@ronagronag added the stream Issues and PRs related to the stream subsystem. label Nov 13, 2021
@ronagronag requested a review from mcollinaNovember 13, 2021 13:04
@ronag
Copy link
MemberAuthor

@nodejs/streams

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 13, 2021
@ronagronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 13, 2021
@ronagronag requested a review from lpincaNovember 13, 2021 16:26
@ronagronag removed the needs-ci PRs that need a full CI run. label Nov 13, 2021
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2021
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag
Copy link
MemberAuthor

Landed in 640bfb8

@ronagronag closed this Nov 15, 2021
ronag added a commit that referenced this pull request Nov 15, 2021
PR-URL: #40801Fixes: #40800 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Nov 21, 2021
PR-URL: #40801Fixes: #40800 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@targostargos mentioned this pull request Nov 26, 2021
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
PR-URL: #40801Fixes: #40800 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
PR-URL: #40801Fixes: #40800 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

non readable Duplex should not be readableAborted

6 participants

@ronag@nodejs-github-bot@mcollina@jasnell@lpinca@juanarbol