Skip to content

doc: simplify major release preparation#40816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Dec 8, 2021
Merged

doc: simplify major release preparation #40816

nodejs-github-bot merged 1 commit into from
Dec 8, 2021

Conversation

@BethGriggs
Copy link
Member

@BethGriggsBethGriggs commented Nov 15, 2021

Proposed simplification of the major release process.

Changes/rational:

  • Change the branch creation to two months prior from three months prior.
    • No builds are run until 6 weeks before so there's no significant impact of creating the branches any earlier.
  • Do not cherry-pick commits within the last month. Mirror the master branch up until 1 week before the release.
    • Mirroring the branches for as long as possible keeps the Git history in sync.
  • Dropped 'semver major cut-off' and replace with 'Inform TSC of any majors which land within a month of the release'.
    • Majors are already gated with TSC approvals at land time.
    • We've had almost no objections for majors for the past few releases - and when there is an objection we have almost always reverted on master too.
    • Asking if there's any objections to the majors is a somewhat tiresome process, and in recent releases I've found there has been minimal engagement. (We're all busy people and it is easy to miss notifications.)

cc: @nodejs/releasers @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 15, 2021
mcollina
mcollina approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

aduh95
aduh95 approved these changes Nov 15, 2021
View reviewed changes
@BethGriggsBethGriggs added the release-agenda Issues and PRs to discuss during the meetings of the Release team. label Nov 16, 2021
mhdawson
mhdawson approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BethGriggsBethGriggs mentioned this pull request Nov 17, 2021
Closed
@BethGriggs
doc: simplify major release preparation
068abb6
Changes/rational: - Change the branch creation to two months prior from three months prior to the release. - Do not cherry-pick commits within the last month - mirror the master branch up until 1 week before the release. - Dropped 'semver major cut-off' and replace with 'Inform TSC of any majors which land within a month of the release'.
@BethGriggsBethGriggs added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2021
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2021
@nodejs-github-botnodejs-github-bot merged commit 18ff583 into nodejs:masterDec 8, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2021

Landed in 18ff583

danielleadams pushed a commit that referenced this pull request Dec 13, 2021
@BethGriggs@danielleadams
doc: simplify major release preparation
302d6ec
Changes/rational: - Change the branch creation to two months prior from three months prior to the release. - Do not cherry-pick commits within the last month - mirror the master branch up until 1 week before the release. - Dropped 'semver major cut-off' and replace with 'Inform TSC of any majors which land within a month of the release'. PR-URL: #40816 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@BethGriggs@danielleadams
doc: simplify major release preparation
e3ac384
Changes/rational: - Change the branch creation to two months prior from three months prior to the release. - Do not cherry-pick commits within the last month - mirror the master branch up until 1 week before the release. - Dropped 'semver major cut-off' and replace with 'Inform TSC of any majors which land within a month of the release'. PR-URL: #40816 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Dec 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@BethGriggs@danielleadams
doc: simplify major release preparation
2fbd3d9
Changes/rational: - Change the branch creation to two months prior from three months prior to the release. - Do not cherry-pick commits within the last month - mirror the master branch up until 1 week before the release. - Dropped 'semver major cut-off' and replace with 'Inform TSC of any majors which land within a month of the release'. PR-URL: #40816 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@BethGriggs@danielleadams
doc: simplify major release preparation
a328f59
Changes/rational: - Change the branch creation to two months prior from three months prior to the release. - Do not cherry-pick commits within the last month - mirror the master branch up until 1 week before the release. - Dropped 'semver major cut-off' and replace with 'Inform TSC of any majors which land within a month of the release'. PR-URL: #40816 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@BethGriggs@Linkgoron
doc: simplify major release preparation
73d608c
Changes/rational: - Change the branch creation to two months prior from three months prior to the release. - Do not cherry-pick commits within the last month - mirror the master branch up until 1 week before the release. - Dropped 'semver major cut-off' and replace with 'Inform TSC of any majors which land within a month of the release'. PR-URL: nodejs#40816 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@BethGriggs@danielleadams
doc: simplify major release preparation
e401e6c
Changes/rational: - Change the branch creation to two months prior from three months prior to the release. - Do not cherry-pick commits within the last month - mirror the master branch up until 1 week before the release. - Dropped 'semver major cut-off' and replace with 'Inform TSC of any majors which land within a month of the release'. PR-URL: #40816 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Danielle Adams <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
@BethGriggsBethGriggs mentioned this pull request Mar 9, 2022
Merged
@RafaelGSSRafaelGSS mentioned this pull request Sep 13, 2022
Merged
@BethGriggsBethGriggs deleted the major-releases-edits branch March 6, 2023 23:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@TrottTrottTrott approved these changes

@cjihrigcjihrigcjihrig approved these changes

@ronagronagronag approved these changes

@tniessentniessentniessen approved these changes

@richardlaurichardlaurichardlau approved these changes

@mhdawsonmhdawsonmhdawson approved these changes

@aduh95aduh95aduh95 approved these changes

+1 more reviewer

@danielleadamsdanielleadamsdanielleadams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.release-agendaIssues and PRs to discuss during the meetings of the Release team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@BethGriggs@nodejs-github-bot@mcollina@Trott@cjihrig@ronag@tniessen@richardlau@danielleadams@mhdawson@aduh95