src: define Is* util functions with macros#4118
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fishrock123 added the c++ 
src/node_util.cc Outdated
Member
There was a problem hiding this comment.
You can improve on this with a map macro:
#defineVALUE_METHOD_MAP(V) \ V(isArrayBuffer, IsArrayBuffer) \ V(isDataView, IsDataView) \ // etc.Then:
#defineV(_, ucname) \ staticvoiducname(const FunctionCallbackInfo<Value>& args){\ // etc.VALUE_METHOD_MAP(V) #undef VAnd further down below:
#defineV(lcname, ucname) env->SetMethod(target, #lcname, ucname); VALUE_METHOD_MAP(V) #undef V
ContributorAuthor
cjihrig commented Dec 2, 2015
@bnoordhuis updated |
Member
jasnell commented Dec 3, 2015
LGTM |
Member
jasnell commented Dec 3, 2015
Marking this as an LTS watch but I'm not convinced yet we should land it there. |
Member
bnoordhuis commented Dec 3, 2015
LGTM |
ContributorAuthor
cjihrig commented Dec 4, 2015
cjihrig added a commit to cjihrig/node that referenced this pull request Dec 4, 2015
The Is* type checking functions in node_util.cc are mostly the same boilerplate. This commit defines them using a macro. Refs: nodejs#4100 PR-URL: nodejs#4118 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
cjihrig added a commit that referenced this pull request Dec 5, 2015
The Is* type checking functions in node_util.cc are mostly the same boilerplate. This commit defines them using a macro. Refs: #4100 PR-URL: #4118 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Dec 8, 2015
Closed
Contributor
MylesBorins commented Dec 29, 2015
this relies on #4100 to land |
cjihrig added a commit to cjihrig/node that referenced this pull request Jan 7, 2016
The Is* type checking functions in node_util.cc are mostly the same boilerplate. This commit defines them using a macro. Refs: nodejs#4100 PR-URL: nodejs#4118 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Conflicts: src/node_util.cc
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
The Is* type checking functions in node_util.cc are mostly the same boilerplate. This commit defines them using a macro. Refs: #4100 PR-URL: #4118 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Conflicts: src/node_util.cc
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
The Is* type checking functions in node_util.cc are mostly the same boilerplate. This commit defines them using a macro. Refs: nodejs#4100 PR-URL: nodejs#4118 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Is*type checking functions innode_util.ccare mostly the same boilerplate. This commit defines them using a macro.Refs: #4100
R=@bnoordhuis