util: display a present-but-undefined error cause#41247
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ljharbforce-pushed the util-inspect-undefined-cause branch from 29c7b48 to eb46007Compare
aduh95 approved these changes Dec 20, 2021
Contributor
aduh95 left a comment
aduh95 left a comment There was a problem hiding this comment.
Firefox output is:
Error: undefined cause <anonymous> debugger eval code:1 Caused by: undefined 
aduh95 added author ready 
github-actionsbot removed the request-ci 
This comment has been minimized.
This comment has been minimized.
cjihrig approved these changes Dec 20, 2021
ljharbforce-pushed the util-inspect-undefined-cause branch from eb46007 to d318e47Compare
targos approved these changes Dec 20, 2021
Collaborator
nodejs-github-bot commented Dec 20, 2021
BridgeAR approved these changes Dec 20, 2021
MemberAuthor
ljharb commented Dec 20, 2021
What's next to land this? :-) |
lpinca approved these changes Dec 20, 2021
targos added the commit-queue 
nodejs-github-bot added commit-queue-failed Collaborator
nodejs-github-bot commented Dec 20, 2021
Commit Queue failed- Loading data for nodejs/node/pull/41247 ✔ Done loading data for nodejs/node/pull/41247 ----------------------------------- PR info ------------------------------------ Title util: display a present-but-undefined error cause (#41247) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch ljharb:util-inspect-undefined-cause -> nodejs:master Labels util, author ready, needs-ci Commits 1 - util: display a present-but-undefined error cause Committers 1 - Jordan Harband PR-URL: https://github.com/nodejs/node/pull/41247 Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Michaël Zasso Reviewed-By: Ruben Bridgewater Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41247 Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Michaël Zasso Reviewed-By: Ruben Bridgewater Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 19 Dec 2021 23:34:01 GMT ✔ Approvals: 5 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41247#pullrequestreview-835919665 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41247#pullrequestreview-835922609 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/41247#pullrequestreview-836065279 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/41247#pullrequestreview-836157757 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41247#pullrequestreview-836782076 ✖ This PR needs to wait 26 more hours to land ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-12-20T08:37:03Z: https://ci.nodejs.org/job/node-test-pull-request/41555/ - Querying data for job/node-test-pull-request/41555/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1603912136 |
Member
targos commented Dec 20, 2021
|
MemberAuthor
ljharb commented Dec 20, 2021
@targos aha, thanks :-) i'll wait out the time then |
tniessen approved these changes Dec 20, 2021
22 tasks
jasnell approved these changes Dec 21, 2021
jasnell removed the commit-queue-failed MemberAuthor
ljharb commented Dec 21, 2021
It's now been 26 hours since that failure; would someone mind kicking off the commit queue? 🙏 |
Contributor
aduh95 commented Dec 21, 2021
✖ This PR needs to wait 21 more minutes to land |
aduh95 added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Dec 21, 2021
Landed in 8d1f13b |
21 tasks
MemberAuthor
ljharb commented Dec 22, 2021
Thanks everyone! |
MemberAuthor
ljharb commented Dec 22, 2021
Can/should this get the backport requested label for node 17? |
Member
BridgeAR commented Dec 22, 2021
@ljharb adding that label is an indicator that there's need for a manual backport and it won't be pulled in automatically anymore. As a patch, it is likely to be pulled into the next releases that contain the basic implementation. |
This was referenced Dec 23, 2021
targos pushed a commit that referenced this pull request Jan 14, 2022
See #41097 (comment) PR-URL: #41247 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
See #41097 (comment) PR-URL: #41247 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
See nodejs#41097 (comment) PR-URL: nodejs#41247 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
See #41097 (comment) PR-URL: #41247 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #41097 (comment)
It was a very explicit and intentional decision to differentiate an
undefinedcause from an absent cause, so let's display it.cc @nodejs/util