child_process: revise argument processing#41280
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added child_process 
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Dec 22, 2021
aduh95 reviewed Dec 22, 2021
Contributor
aduh95 left a comment
aduh95 left a comment There was a problem hiding this comment.
Suggestions that make this change semver-major, but also more "correct", so maybe it's worth it?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
execFile() and fork() have complicated argument processing. Clarify code and avoid using `arguments`.
Trottforce-pushed the child-process-args branch from 79f3573 to a749686Compare
jasnell approved these changes Dec 22, 2021
aduh95 approved these changes Dec 23, 2021
This comment has been minimized.
This comment has been minimized.
aduh95 added the author ready Collaborator
nodejs-github-bot commented Dec 23, 2021
18 tasks
Trott added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Dec 24, 2021
Landed in 4069e7e |
This was referenced Dec 25, 2021
This was referenced Jan 1, 2022
25 tasks
targos pushed a commit that referenced this pull request Jan 14, 2022
execFile() and fork() have complicated argument processing. Clarify code and avoid using `arguments`. PR-URL: #41280 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
execFile() and fork() have complicated argument processing. Clarify code and avoid using `arguments`. PR-URL: #41280 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
execFile() and fork() have complicated argument processing. Clarify code and avoid using `arguments`. PR-URL: nodejs#41280 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
execFile() and fork() have complicated argument processing. Clarify code and avoid using `arguments`. PR-URL: #41280 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execFile() and fork() have complicated argument processing. Clarify code
and avoid using
arguments.