build: remove Python 2 workaround#41357
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Remove workaround for Python 2. I confirmed that V8 build still works by running `./configure.py && make v8`.
nodejs-github-bot added build 
MemberAuthor
Trott commented Dec 30, 2021
/ping @nodejs/v8-update in case this is premature |
tniessen approved these changes Dec 30, 2021
Member
targos commented Dec 30, 2021
MemberAuthor
Trott commented Dec 30, 2021
V8 CI is green. |
github-actionsbot removed the request-ci 
Collaborator
nodejs-github-bot commented Dec 30, 2021
lpinca approved these changes Dec 30, 2021
Collaborator
nodejs-github-bot commented Dec 30, 2021
Trott added the author ready Collaborator
nodejs-github-bot commented Dec 30, 2021
26 tasks
gengjiawen approved these changes Dec 31, 2021
Lxxyx approved these changes Dec 31, 2021
24 tasks
Trott added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Jan 1, 2022
Landed in 5999731 |
This was referenced Jan 2, 2022
18 tasks
targos pushed a commit that referenced this pull request Jan 14, 2022
Remove workaround for Python 2. I confirmed that V8 build still works by running `./configure.py && make v8`. PR-URL: #41357 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Remove workaround for Python 2. I confirmed that V8 build still works by running `./configure.py && make v8`. PR-URL: #41357 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
Remove workaround for Python 2. I confirmed that V8 build still works by running `./configure.py && make v8`. PR-URL: nodejs#41357 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Remove workaround for Python 2. I confirmed that V8 build still works by running `./configure.py && make v8`. PR-URL: #41357 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove workaround for Python 2.
I confirmed that V8 build still works by running
./configure.py && make v8.