Skip to content

tools: replace for loop with map()#41451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Trott merged 1 commit into from
Jan 13, 2022
Merged

tools: replace for loop with map() #41451

Trott merged 1 commit into from
Jan 13, 2022

Conversation

@Trott
Copy link
Member

@TrottTrott commented Jan 9, 2022

Refs: #41406 (comment)
Co-authored-by: Tobias Nießen [email protected]

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Jan 9, 2022
@TrottTrott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 9, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/41796/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 9, 2022
antsmartian
antsmartian approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@antsmartianantsmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 11, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/41820/

@github-actionsgithub-actionsbot mentioned this pull request Jan 12, 2022
Open
20 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 12, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/41845/

@github-actionsgithub-actionsbot mentioned this pull request Jan 13, 2022
Open
18 tasks
@Trott
tools: replace for loop with map()
500241d
Refs: nodejs#41406 (comment) Co-authored-by: Tobias Nießen <[email protected]> PR-URL: nodejs#41451 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
@Trott
Copy link
MemberAuthor

Trott commented Jan 13, 2022

Landed in 500241d

@TrottTrott merged commit 500241d into nodejs:masterJan 13, 2022
@TrottTrott deleted the map-it branch January 13, 2022 06:11
@github-actionsgithub-actionsbot mentioned this pull request Jan 14, 2022
Open
22 tasks
targos pushed a commit that referenced this pull request Jan 14, 2022
@Trott@targos
tools: replace for loop with map()
ec337b2
Refs: #41406 (comment) Co-authored-by: Tobias Nießen <[email protected]> PR-URL: #41451 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
@github-actionsgithub-actionsbot mentioned this pull request Jan 15, 2022
Open
26 tasks
@targostargos mentioned this pull request Jan 16, 2022
Merged
mawaregetsuka pushed a commit to mawaregetsuka/node that referenced this pull request Jan 17, 2022
@Trott@mawaregetsuka
tools: replace for loop with map()
1406726
Refs: nodejs#41406 (comment) Co-authored-by: Tobias Nießen <[email protected]> PR-URL: nodejs#41451 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
thedull pushed a commit to thedull/node that referenced this pull request Jan 18, 2022
@Trott@thedull
tools: replace for loop with map()
c579369
Refs: nodejs#41406 (comment) Co-authored-by: Tobias Nießen <[email protected]> PR-URL: nodejs#41451 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott@Linkgoron
tools: replace for loop with map()
165c02f
Refs: nodejs#41406 (comment) Co-authored-by: Tobias Nießen <[email protected]> PR-URL: nodejs#41451 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott@danielleadams
tools: replace for loop with map()
86ece98
Refs: #41406 (comment) Co-authored-by: Tobias Nießen <[email protected]> PR-URL: #41451 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
@danielleadamsdanielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes

@tniessentniessentniessen approved these changes

+1 more reviewer

@antsmartianantsmartianantsmartian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@nodejs-github-bot@addaleax@antsmartian@tniessen