src: define getpid() based on OS#4146
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
mscdex commented Dec 4, 2015
I believe we can forgo including |
ContributorAuthor
cjihrig commented Dec 4, 2015
I think you're right. Updating. |
ContributorAuthor
cjihrig commented Dec 4, 2015
Updated. |
ContributorAuthor
cjihrig commented Dec 4, 2015
ContributorAuthor
cjihrig commented Dec 4, 2015
Only CI failures are known flakey tests. |
Contributor
mscdex commented Dec 4, 2015
LGTM |
cjihrig added a commit to cjihrig/node that referenced this pull request Dec 4, 2015
94b9948 added unistd.h to src/env.cc in order to use getpid(). However, this doesn't exist on Windows. This commit conditionally defines getpid() based on the OS. Fixes: nodejs#4145 PR-URL: nodejs#4146 Reviewed-By: Brian White <[email protected]>
ContributorAuthor
cjihrig commented Dec 4, 2015
Thanks for the review. Landing this more quickly than normal since the Windows CI was borked. |
Member
rvagg commented Dec 5, 2015
commits missing again, perhaps this is what github is doing now if you don't update your PR with the latest version of the commits and delete the branch? |
cjihrig added a commit that referenced this pull request Dec 5, 2015
94b9948 added unistd.h to src/env.cc in order to use getpid(). However, this doesn't exist on Windows. This commit conditionally defines getpid() based on the OS. Fixes: #4145 PR-URL: #4146 Reviewed-By: Brian White <[email protected]>
This was referenced Dec 8, 2015
Closed
jasnell added os 
Contributor
MylesBorins commented Dec 29, 2015
94b9948 was semver major so I do not believe this patch should be backported. @jasnell feel free to modify. |
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
94b9948 added unistd.h to src/env.cc in order to use getpid(). However, this doesn't exist on Windows. This commit conditionally defines getpid() based on the OS. Fixes: nodejs#4145 PR-URL: nodejs#4146 Reviewed-By: Brian White <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
94b9948 added
unistd.htosrc/env.ccin order to usegetpid(). However, this doesn't exist on Windows. This commit conditionally definesgetpid()based on the OS.Closes#4145
R=@mscdex