tools: backport tools/install.py for headers

[richardlau]

Backport the tools/install.py changes from 628a3ab that were missed
when 6fb0b92 backported the corresponding changes to the Makefile to
build the headers only archive.

Fixes#4140

[mscdex]

Maybe it would be better to target tools: instead of build:?

[rvagg]

lgtm, thanks @richardlau

I have no opinion on tools: vs build:

[richardlau]

I've tested by running HEADERS_ONLY=1 python tools/install.py install 'node-v0.12.10' '/' and inspecting the contents of the created node-v0.12.10 directory.

I tried to run make tar-headers but ran into some problems:

1. First I see this, which is easily patched around

#NODE_VERSION_IS_RELEASE is set to 0. Did you remember to update src/node_version.h? 

2. If I patch src/node_version.h for 1) I then get:

find node-v0.12.10/ -type l | xargs rm # annoying on windows rm: missing operand Try `rm --help' for more information. make: *** [node-v0.12.10.tar-headers] Error 123 

But I also get the same problem with v4.x.

[richardlau]

@mscdex I can retarget to tools: if required -- I picked build: because the two commits referenced were targeted at build:.

[richardlau]

This also affects v0.10 -- Please could someone add a lts-watch-v0.10 label?

[richardlau]

Retargetted to tools:.

[rvagg]

@richardlau are you on Linux? the xargs thing works on OS X and that's what's used to generate the tarball. I've tried out your branch and it works fine on OS X but not on Linux, that's ... how it is and it kind of sucks but nobody has got around to fixing it yet. There's two instances of the same pattern in there.

[richardlau]

@rvagg Yes I'm on Linux -- Didn't realize that the tarball was generated on OS X. Thanks.

[rvagg]

still lgtm, needs to sit for additional reviews and possible objection for a couple of days but someone can land it after that (I'll do it if I remember but any other collaborator can)

[bnoordhuis]

Untested but LGTM.

[rvagg]

sorry, I should have posted results of my testing on 0.12:

$ make tar-headers /usr/local/opt/python/bin/python2.7 ./configure \ --prefix=/ \ --dest-cpu=x64 \ --tag= \ --download=all --with-intl=small-icu creating ./icu_config.gypi ... configure blah blah ... creating ./config.gypi creating ./config.mk HEADERS_ONLY=1 /usr/local/opt/python/bin/python2.7 tools/install.py install 'node-v0.12.10' '/' .. list of files blah blah .. find node-v0.12.10/ -type l | xargs rm # annoying on windows tar -cf node-v0.12.10-headers.tar node-v0.12.10 rm -rf node-v0.12.10 gzip -c -f -9 node-v0.12.10-headers.tar > node-v0.12.10-headers.tar.gz rm node-v0.12.10-headers.tar $ ls -al node-v0.12.10-headers.tar.gz -rw-r--r-- 1 rvagg staff 444046 4 Dec 23:07 node-v0.12.10-headers.tar.gz 

The full contents of the resulting file is listed here: https://gist.github.com/rvagg/e86237fb9d838ae57a62

[jbergstroem]

LGTM

[rvagg]

lgtm

landed in v0.12-staging @ 5f0b675
landed in v0.10-staging @ 28ab7b0