[v14.x backport] esm: make process.exit() default to exit code 0#41508
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Due to a bug in top-level await implementation, it used to default to exit code 13. PR-URL: nodejs#41388Fixes: nodejs#40808 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
aduh95 added experimental 
Collaborator
nodejs-github-bot commented Jan 14, 2022
Review requested:
|
nodejs-github-bot added needs-ci 
guybedford approved these changes Jan 14, 2022
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Richard Lau <[email protected]>
hybrist approved these changes Jan 14, 2022
github-actionsbot removed the request-ci Collaborator
nodejs-github-bot commented Jan 14, 2022
Collaborator
nodejs-github-bot commented Jan 14, 2022
Collaborator
nodejs-github-bot commented Jan 14, 2022
26 tasks
Collaborator
nodejs-github-bot commented Jan 15, 2022
Collaborator
nodejs-github-bot commented Jan 15, 2022
Collaborator
16 tasks
richardlau pushed a commit that referenced this pull request Jan 25, 2022
Due to a bug in top-level await implementation, it used to default to exit code 13. PR-URL: #41388 Backport-PR-URL: #41508Fixes: #40808 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Member
richardlau commented Jan 25, 2022
Landed in a90defe. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a bug in top-level await implementation, it used to default to
exit code 13.
PR-URL: #41388
Fixes: #40808
Reviewed-By: Antoine du Hamel [email protected]
Reviewed-By: Guy Bedford [email protected]