Skip to content

tool: Fixed bug causing JSON format to be broken#41565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Mar 31, 2022
Merged

tool: Fixed bug causing JSON format to be broken #41565

nodejs-github-bot merged 1 commit into from
Mar 31, 2022

Conversation

@mawaregetsuka
Copy link
Contributor

@mawaregetsukamawaregetsuka commented Jan 17, 2022

The JSON format in the current version of the config.gypi file can be broken because the pprint.pformat function splits the argument string into multiple lines if it is long enough and contains Spaces

./configure --v8-options="--this_is_parameter_one --this_is_parmaeter_two" //This is the corresponding line in configure.gypi 'node_v8_options': '--this_is_parameter_one ' '--this_is_parmaeter_two',

You can see that function pprint.pformat accidentally splits the string into two lines, causing the JSON format to be broken

I can think of three solutions

1 Abandon the line length limit

2 Use regular matches after pprint.pformat

3 Manually implement an appropriate print function

I chose the simplest solution for this PR and am glad to work on other solutions if the administrator thinks it is necessary

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jan 17, 2022
@mawaregetsukamawaregetsukaforce-pushed the local branch 2 times, most recently from 1d07a99 to 0d7ce77CompareJanuary 17, 2022 04:43
@TrottTrott added the python PRs and issues that require attention from people who are familiar with Python. label Jan 17, 2022
@benjamingrbenjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 27, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/42811/

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 12, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 12, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/42956/

@github-actionsgithub-actionsbot mentioned this pull request Mar 14, 2022
Open
28 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 14, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43030/

@github-actionsgithub-actionsbot mentioned this pull request Mar 15, 2022
Open
20 tasks
@mawaregetsuka
Copy link
ContributorAuthor

mawaregetsuka commented Mar 23, 2022

Need help.
Why the ci is still in pending state?

@mawaregetsuka
Copy link
ContributorAuthor

mawaregetsuka commented Mar 30, 2022

@aduh95
Can you give some help for this pr?

@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 31, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43240/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 31, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43243/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2022
@nodejs-github-botnodejs-github-bot merged commit 605a01b into nodejs:masterMar 31, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 31, 2022

Landed in 605a01b

@mawaregetsuka
Copy link
ContributorAuthor

mawaregetsuka commented Mar 31, 2022

@aduh95
Thank you for your help!

juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
@mawaregetsuka@juanarbol
tools: fixed bug causing JSON format to be broken
4dfc29d
PR-URL: nodejs#41565 Reviewed-By: James M Snell <[email protected]>
This was referenced Apr 5, 2022
Closed
Merged
@mawaregetsukamawaregetsuka mentioned this pull request Apr 5, 2022
Open
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
@mawaregetsuka@juanarbol
tools: fixed bug causing JSON format to be broken
a9f2636
PR-URL: #41565 Reviewed-By: James M Snell <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@mawaregetsuka@xtx1130
tools: fixed bug causing JSON format to be broken
c947e28
PR-URL: nodejs#41565 Reviewed-By: James M Snell <[email protected]>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@mawaregetsuka@juanarbol
tools: fixed bug causing JSON format to be broken
321539c
PR-URL: #41565 Reviewed-By: James M Snell <[email protected]>
@juanarboljuanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@mawaregetsuka@danielleadams
tools: fixed bug causing JSON format to be broken
b0e1501
PR-URL: #41565 Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
@mawaregetsuka@targos
tools: fixed bug causing JSON format to be broken
d6fa43c
PR-URL: #41565 Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
@mawaregetsuka@targos
tools: fixed bug causing JSON format to be broken
51cfb6c
PR-URL: #41565 Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@mawaregetsuka@targos
tools: fixed bug causing JSON format to be broken
282b449
PR-URL: #41565 Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@mawaregetsuka@guangwong
tools: fixed bug causing JSON format to be broken
124a5fc
PR-URL: nodejs/node#41565 Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.pythonPRs and issues that require attention from people who are familiar with Python.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mawaregetsuka@nodejs-github-bot@jasnell@Trott@benjamingr@aduh95