Skip to content

Conversation

@Trott
Copy link
Member

@TrottTrott commented Dec 5, 2015

test-cluster-shared-leak is flaky on Windows.

Ref: #3956

test-cluster-shared-leak is flaky on Windows. Ref: nodejs#3956
@TrottTrott added windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. labels Dec 5, 2015
@Trott
Copy link
MemberAuthor

Trott commented Dec 5, 2015

Also took the opportunity to alphabetize the list of flaky tests on Windows.

@bnoordhuis
Copy link
Member

LGTM

2 similar comments
@r-52
Copy link
Contributor

r-52 commented Dec 5, 2015

LGTM

@JungMinu
Copy link
Member

LGTM

@mscdexmscdex added the cluster Issues and PRs related to the cluster subsystem. label Dec 5, 2015
Trott added a commit that referenced this pull request Dec 6, 2015
test-cluster-shared-leak is flaky on Windows. Refs: #3956 PR-URL: #4162 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
@r-52
Copy link
Contributor

r-52 commented Dec 6, 2015

Thanks @Trott - Landed in afd5122

@r-52r-52 closed this Dec 6, 2015
Trott added a commit that referenced this pull request Dec 8, 2015
test-cluster-shared-leak is flaky on Windows. Refs: #3956 PR-URL: #4162 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
@rvaggrvagg mentioned this pull request Dec 17, 2015
Trott added a commit that referenced this pull request Dec 29, 2015
test-cluster-shared-leak is flaky on Windows. Refs: #3956 PR-URL: #4162 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
test-cluster-shared-leak is flaky on Windows. Refs: #3956 PR-URL: #4162 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
test-cluster-shared-leak is flaky on Windows. Refs: nodejs#3956 PR-URL: nodejs#4162 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Klauke <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
@TrottTrott deleted the double-secret-probation branch January 13, 2022 22:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clusterIssues and PRs related to the cluster subsystem.testIssues and PRs related to the tests.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@bnoordhuis@r-52@JungMinu@mscdex@jasnell@MylesBorins