add: scheduler config option for cluster#42308
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added cluster 
yashLadhaforce-pushed the add_customer_scheduler branch from 286733a to 645b540CompareyashLadhaforce-pushed the add_customer_scheduler branch 5 times, most recently from cbe6731 to 21d893dCompare
This comment was marked as duplicate.
This comment was marked as duplicate.
yashLadhaforce-pushed the add_customer_scheduler branch from 21d893d to 581a209Compare This comment was marked as outdated.
This comment was marked as outdated.
yashLadhaforce-pushed the add_customer_scheduler branch from 581a209 to 87bc466Compare This comment was marked as outdated.
This comment was marked as outdated.
yashLadhaforce-pushed the add_customer_scheduler branch from 87bc466 to 9dec344Compare This comment was marked as outdated.
This comment was marked as outdated.
yashLadhaforce-pushed the add_customer_scheduler branch from 9dec344 to e3980ffComparenodejs-github-bot commented Mar 13, 2022
Opening this for initial review. Will add the docs later after the finalisation. |
yashLadhaforce-pushed the add_customer_scheduler branch from e3980ff to 40302e5Compare
| functionvalidateAndReturnScheduler(scheduler,schedulingPolicy){ | ||
| if(scheduler!==undefined){ | ||
| if(typeofscheduler.execute!=='function'){ | ||
| thrownewERR_CLUSTER_INVALID_SCHEDULER('scheduler.execute'); |
There was a problem hiding this comment.
Not sure this warrants a new error code. ERR_INVALID_ARG_TYPE would probably still work here.
There was a problem hiding this comment.
INVALID_ARG_TYPE seems very broad and that's why i made the choice of ERR_CLUSTER_INVALID_SCHEDULER. Will update the use to INVALID_ARG_TYPE.
yashLadhaforce-pushed the add_customer_scheduler branch from 40302e5 to 8328c98Compare
cjihrig commented Apr 10, 2022
It's nice to see this picked back up. Just a word of caution @yashLadha - I don't know how popular |
yashLadha commented Apr 23, 2022
@cjihrig Sure, reason why i wanted this being i also faced similar issue at one the projects and though if this is part of core cluster then that would be awesome. |
scheduler let's use a custom scheduler function for scheduling workers.
yashLadhaforce-pushed the add_customer_scheduler branch from 8328c98 to 5cbeb35Compare
4 participants
This is a WIP PR for adding custom scheduler to cluster.
Will add the doc changes later after the finalisation of structure in PR.