doc: expand history for conditional exports changes in v12#42339
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Mar 15, 2022
Review requested:
|
Member
ljharb commented Mar 15, 2022
LGTM, thanks |
JakobJingleheimer approved these changes Mar 15, 2022
Member
JakobJingleheimer left a comment
JakobJingleheimer left a comment There was a problem hiding this comment.
Based on the previous discussions I presume the info is accurate, so LGTM
GeoffreyBooth approved these changes Mar 15, 2022
jasnell approved these changes Mar 25, 2022
JakobJingleheimer added commit-queue 
nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Mar 26, 2022
Landed in 6e54851 |
juanarbol pushed a commit that referenced this pull request Apr 4, 2022
Fixes: #36162 PR-URL: #42339 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
Fixes: nodejs#36162 PR-URL: nodejs#42339 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]>
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
Fixes: #36162 PR-URL: #42339 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
Fixes: nodejs#36162 PR-URL: nodejs#42339 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]>
juanarbol pushed a commit that referenced this pull request May 31, 2022
Fixes: #36162 PR-URL: #42339 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
Fixes: #36162 PR-URL: #42339 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
Fixes: #36162 PR-URL: #42339 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
Fixes: #36162 PR-URL: #42339 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Fixes: nodejs/node#36162 PR-URL: nodejs/node#42339 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on #42336 this change adds some extra detail to the history of unflagging conditional exports across v12.16 and v2.17. In v13 conditional exports became fully unflagged in v13.7 when
--experimental-conditional-exportswas removed.Unfortunately the version order linting rule doesn't allow putting the removal of
--experimental-modulesfor just 12.17.0 above the removal of--experimental-conditional-exportsin both 12.16.0 and 13.7.0, but hopefully the change there is still clear.Fixes: #36162