Skip to content

Conversation

@richardlau
Copy link
Member

@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2022
@nodejs-github-botnodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. v14.x labels Mar 15, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2022
@nodejs-github-bot

This comment was marked as outdated.

@richardlau
Copy link
MemberAuthor

https://github.com/nodejs/node/runs/5558087600?check_suite_focus=true
I'll push a commit later to pin the actions onto windows-2019 instead of windows-latest and hope that fixes the workflow for Node.js 14 🤞.

@richardlau
Copy link
MemberAuthor

https://github.com/nodejs/node/runs/5558087600?check_suite_focus=true I'll push a commit later to pin the actions onto windows-2019 instead of windows-latest and hope that fixes the workflow for Node.js 14 🤞.

#42350 does just that and appears to work.

bengland others added 3 commits March 15, 2022 19:24
Adds Bryan English and his public key to the README for releases. PR-URL: nodejs#42102 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Danielle Adams <[email protected]>
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1n.tar.gz $ mv openssl-1.1.1n openssl $ git add --all openssl $ git commit openssl
After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make -C deps/openssl/config $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

Copy link
Member

@joesepijoesepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlaurichardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 16, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

@VoltrexKeyvaVoltrexKeyva removed the needs-ci PRs that need a full CI run. label Mar 16, 2022
richardlau added a commit that referenced this pull request Mar 16, 2022
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1n.tar.gz $ mv openssl-1.1.1n openssl $ git add --all openssl $ git commit openssl PR-URL: #42347 Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-March/000218.html Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Joe Sepi <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
richardlau added a commit that referenced this pull request Mar 16, 2022
After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make -C deps/openssl/config $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: #42347 Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-March/000218.html Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Joe Sepi <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
@richardlau
Copy link
MemberAuthor

Landed in b5c52e3...3b1a0b2.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency file.fast-trackPRs that do not need to wait for 48 hours to land.opensslIssues and PRs related to the OpenSSL dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@richardlau@nodejs-github-bot@joesepi@Trott@tniessen@mhdawson@RaisinTen@VoltrexKeyva@bengl