Skip to content

tools: fix skip PR if CI is still running#42377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 2 commits into from
Mar 21, 2022
Merged

tools: fix skip PR if CI is still running #42377

nodejs-github-bot merged 2 commits into from
Mar 21, 2022

Conversation

@meixg
Copy link
Member

@meixgmeixg commented Mar 17, 2022•
edited by aduh95
Loading

The original "Skip PR if CI is still running" seems not working, I find it is because ncu-ci url's output can't be greped (not totally sure because I don't have access to jenkins).

Using gh pr checks should be just fine I guess.

Fixes: #40330

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 17, 2022

Review requested:

  • @nodejs/actions

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 17, 2022
aduh95
aduh95 reviewed Mar 17, 2022
View reviewed changes
@aduh95
Copy link
Contributor

aduh95 commented Mar 17, 2022

The original "Skip PR if CI is still running" seems not working, I find it is because ncu-ci url's output can't be greped (not totally sure because I don't have access to jenkins).

ncu-ci output can be greped AFAICT. I think the problem comes from the fact that ncu-ci only checks Jenkins CI, not GitHub Actions ones. I agree that using GitHub CLI should do the trick as it's effectively checking both.

aduh95
aduh95 reviewed Mar 17, 2022
View reviewed changes
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 17, 2022
mhdawson
mhdawson approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meixgmeixg added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 21, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43138/

@meixgmeixg added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 21, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 21, 2022
@nodejs-github-botnodejs-github-bot merged commit 8f07452 into nodejs:masterMar 21, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 21, 2022

Landed in 8f07452

juanarbol pushed a commit that referenced this pull request Apr 4, 2022
@meixg@juanarbol
tools: fix skip PR if CI is still running
e0bb9fc
resolve: #40330 PR-URL: #42377Fixes: #40330 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Mestery <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
@meixg@juanarbol
tools: fix skip PR if CI is still running
17770be
resolve: nodejs#40330 PR-URL: nodejs#42377Fixes: nodejs#40330 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Mestery <[email protected]>
This was referenced Apr 5, 2022
Closed
Merged
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
@meixg@juanarbol
tools: fix skip PR if CI is still running
9344a06
resolve: #40330 PR-URL: #42377Fixes: #40330 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Mestery <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@meixg@xtx1130
tools: fix skip PR if CI is still running
5fa82c6
resolve: nodejs#40330 PR-URL: nodejs#42377Fixes: nodejs#40330 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Mestery <[email protected]>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@meixg@juanarbol
tools: fix skip PR if CI is still running
4122a8d
resolve: #40330 PR-URL: #42377Fixes: #40330 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Mestery <[email protected]>
@juanarboljuanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@meixg@danielleadams
tools: fix skip PR if CI is still running
631ce65
resolve: #40330 PR-URL: #42377Fixes: #40330 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Mestery <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
@meixg@targos
tools: fix skip PR if CI is still running
4080425
resolve: #40330 PR-URL: #42377Fixes: #40330 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Mestery <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@meixg@targos
tools: fix skip PR if CI is still running
4c0ddff
resolve: #40330 PR-URL: #42377Fixes: #40330 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Mestery <[email protected]>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@meixg@guangwong
tools: fix skip PR if CI is still running
1dd4fc9
resolve: nodejs/node#40330 PR-URL: nodejs/node#42377Fixes: nodejs/node#40330 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Mestery <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhdawsonmhdawsonmhdawson approved these changes

@aduh95aduh95aduh95 approved these changes

+1 more reviewer

@MesteeryMesteeryMesteery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The commit-queue label should wait for CI

5 participants

@meixg@nodejs-github-bot@aduh95@mhdawson@Mesteery