doc: simplify recommendations in process.md#42556
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
Mesteery approved these changes Apr 1, 2022
aduh95 approved these changes Apr 1, 2022
benjamingr approved these changes Apr 1, 2022
Trott commented Apr 1, 2022
| The `process` object provides information about, and control over, the current | ||
| Node.js process. While it is available as a global, it is recommended to | ||
| explicitly access it via require or import: | ||
| Node.js process. |
MemberAuthor
There was a problem hiding this comment.
My preference here would be to add text explaining why the global should be avoided, but I don't know what that reason is. Also, with this change, there is now no mention of process being available as a global and that is something that should be mentioned.
Contributor
There was a problem hiding this comment.
It's mentioned here:
Lines 467 to 477 in 175638b
I don't think we need more, especially if the intent is to promote importing/requiring the core module rather than rely on the global property.
marsonya approved these changes Apr 2, 2022
Trott added the commit-queue nodejs-github-bot added commit-queue-failed 
Collaborator
nodejs-github-bot commented Apr 3, 2022
Commit Queue failed- Loading data for nodejs/node/pull/42556 FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close at consumeBody (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60) at processTicksAndRejections (node:internal/process/task_queues:96:5) at async Response.text (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18) at async Request.json (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/lib/request.js:49:18) at async Request.query (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/lib/request.js:107:20) at async Request.queryAll (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/lib/request.js:134:20) at async Request.gql (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/lib/request.js:64:22) at async PRData.getComments (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21) at async Promise.all (index 2) at async Promise.all (index 1){type: 'system', errno: 'ERR_STREAM_PREMATURE_CLOSE', code: 'ERR_STREAM_PREMATURE_CLOSE', erroredSysCall: undefined }https://github.com/nodejs/node/actions/runs/2084373902 |
Remove recommendation that has no explanation. Make the other recommendation less wordy. PR-URL: nodejs#42556 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
MemberAuthor
Trott commented Apr 3, 2022
Landed in b07dc4d |
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
Remove recommendation that has no explanation. Make the other recommendation less wordy. PR-URL: nodejs#42556 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
Remove recommendation that has no explanation. Make the other recommendation less wordy. PR-URL: #42556 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
Remove recommendation that has no explanation. Make the other recommendation less wordy. PR-URL: nodejs#42556 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
juanarbol pushed a commit that referenced this pull request May 31, 2022
Remove recommendation that has no explanation. Make the other recommendation less wordy. PR-URL: #42556 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
Remove recommendation that has no explanation. Make the other recommendation less wordy. PR-URL: #42556 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
Remove recommendation that has no explanation. Make the other recommendation less wordy. PR-URL: #42556 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
Remove recommendation that has no explanation. Make the other recommendation less wordy. PR-URL: #42556 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Remove recommendation that has no explanation. Make the other recommendation less wordy. PR-URL: nodejs/node#42556 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove recommendation that has no explanation. Make the other
recommendation less wordy.