doc: fix outgoingMessage.removeHeader() signature#42652
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Apr 8, 2022
Review requested:
|
nodejs-github-bot added doc Specify that `outgoingMessage.removeHeader()` takes a `name` argument whose type is string.
lpincaforce-pushed the add/missing-argument branch from 3e89179 to d93a1dfComparelpinca changed the title 
ronag approved these changes Apr 8, 2022
VoltrexKeyva approved these changes Apr 8, 2022
cjihrig approved these changes Apr 8, 2022
marsonya approved these changes Apr 9, 2022
marsonya added the author ready 
targos added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Apr 10, 2022
Landed in 13ad8d4 |
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
Specify that `outgoingMessage.removeHeader()` takes a `name` argument whose type is string. PR-URL: nodejs#42652 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
juanarbol pushed a commit that referenced this pull request May 31, 2022
Specify that `outgoingMessage.removeHeader()` takes a `name` argument whose type is string. PR-URL: #42652 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
Specify that `outgoingMessage.removeHeader()` takes a `name` argument whose type is string. PR-URL: #42652 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
Specify that `outgoingMessage.removeHeader()` takes a `name` argument whose type is string. PR-URL: #42652 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
Specify that `outgoingMessage.removeHeader()` takes a `name` argument whose type is string. PR-URL: #42652 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Specify that `outgoingMessage.removeHeader()` takes a `name` argument whose type is string. PR-URL: nodejs/node#42652 Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify that
outgoingMessage.removeHeader()takes anameargumentwhose type is string.