Skip to content

Conversation

@nodejs-github-bot
Copy link
Collaborator

Here are some new additions to the AUTHORS file. This is an automatically generated PR by the authors.yml GitHub Action, which runs tools/update-authors.js.

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 17, 2022
@Trott
Copy link
Member

By the way, if someone is feeling like they want to improve this, the script detects probable duplicates. (Sometimes it flags things as duplicates that aren't--you have to go and look to see if it's two different GitHub accounts that happen to be people with the same name or if it's the same person using two different email addresses. Usually, it's the latter, but not always.)

However, the script/GitHub Action doesn't put that information in the pull request. I always have to go and look for it. (For this one, go to https://github.com/nodejs/node/runs/6050766933?check_suite_focus=true, and expand Run tools/update-authors.js.)

It would be great if that information ended up in the pull request. Sure, it still takes a human to investigate, but at least the information isn't hidden.

@TrottTrottforce-pushed the actions/authors-update branch from 2d99a60 to f41f891CompareApril 17, 2022 00:43
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 17, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 17, 2022
@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2022
@nodejs-github-botnodejs-github-bot merged commit 9724ca2 into masterApr 17, 2022
@nodejs-github-bot
Copy link
CollaboratorAuthor

Landed in 9724ca2

@TrottTrott deleted the actions/authors-update branch April 17, 2022 13:36
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
PR-URL: nodejs#42760 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2022
PR-URL: #42760 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@targostargos mentioned this pull request May 2, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #42760 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #42760 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
PR-URL: #42760 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #42760 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@targostargos mentioned this pull request Aug 3, 2022
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#42760 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nodejs-github-bot@Trott@lpinca@RaisinTen