build: improve the format-cpp error message#42765
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
nodejs-github-bot commented Apr 17, 2022
Review requested:
|
nodejs-github-bot added the meta 
Trott reviewed Apr 17, 2022
Uh oh!
There was an error while loading. Please reload this page.
RaisinTenforce-pushed the build/improve-the-format-cpp-error-message branch from 2e12a44 to d55e95aCompare
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <[email protected]>
RaisinTenforce-pushed the build/improve-the-format-cpp-error-message branch from d55e95a to 25846acCompareTrott approved these changes Apr 17, 2022
RaisinTen added the author ready 
Mesteery approved these changes Apr 17, 2022
gengjiawen approved these changes Apr 18, 2022
lpinca approved these changes Apr 18, 2022
aduh95 added the commit-queue nodejs-github-bot removed the commit-queue Collaborator
nodejs-github-bot commented Apr 19, 2022
Landed in fc326d6 |
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs#42765 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2022
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42765 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
juanarbol pushed a commit that referenced this pull request May 31, 2022
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42765 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42765 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42765 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42765 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs/node#42765 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change specifies the target branch name instead of leaving that to
the committer to fill in.
Signed-off-by: Darshan Sen [email protected]