Skip to content

doc: elevate node-clinic diagnostic tier#42802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RafaelGSS wants to merge 1 commit into from
Closed

doc: elevate node-clinic diagnostic tier #42802

RafaelGSS wants to merge 1 commit into from

Conversation

@RafaelGSS
Copy link
Member

@RafaelGSSRafaelGSS commented Apr 20, 2022

Fixes: nodejs/diagnostics#537.

As discussed in the last Diagnostics WG(nodejs/diagnostics#552). I'm not sure how the node-clinic tests could be integrated into the nightly CI.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 20, 2022

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 20, 2022
@richardlaurichardlau requested a review from a teamApril 20, 2022 16:38
@richardlau
Copy link
Member

richardlau commented Apr 20, 2022

As per https://github.com/nodejs/node/blob/master/doc/contributing/diagnostic-tooling-support-tiers.md#adding-a-tool-to-this-list

Once it has been added to the list "promotion" to Tier 3 through Tier 1 requires that the requirements listed above be met AND have agreement from Diagnostics WG and Release WG based on the criteria listed above.

cc @nodejs/diagnostics @nodejs/releasers

@richardlau
Copy link
Member

richardlau commented Apr 20, 2022

I'm not sure how the node-clinic tests could be integrated into the nightly CI.

Me neither. I think we test it in CITGM but that isn't run nightly.

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Apr 20, 2022

I would consider if possible run in nightly clause to be same in spirit as running in CITGM

mcollina
mcollina approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@mcollinamcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gireeshpunathilgireeshpunathil mentioned this pull request Apr 21, 2022
Closed
@richardlau
Copy link
Member

richardlau commented Apr 21, 2022

I would consider if possible run in nightly clause to be same in spirit as running in CITGM

FWIW clinic is currently skipped in citgm for AIX and Windows: https://github.com/nodejs/citgm/blob/fcfc781e72e6ed79ccd8a4e189960111c55f722a/lib/lookup.json#L97-L102

@mhdawson
Copy link
Member

mhdawson commented Apr 21, 2022

I would consider if possible run in nightly clause to be same in spirit as running in CITGM
+1

I think that if we agree on that, then the entry should be updated to show that test are being run.

@RafaelGSS
Copy link
MemberAuthor

RafaelGSS commented Apr 22, 2022•
edited
Loading

I would consider if possible run in nightly clause to be same in spirit as running in CITGM
+1

I think that if we agree on that, then the entry should be updated to show that test are being run.

Can you elaborate, please? Should I change https://github.com/nodejs/citgm/blob/fcfc781e72e6ed79ccd8a4e189960111c55f722a/lib/lookup.json#L97-L102 to not skip those tests? btw AIX is not supported AFAIK

RafaelGSS added a commit that referenced this pull request Apr 26, 2022
@RafaelGSS
doc: elevate node-clinic diagnostic tier
d8460de
PR-URL: #42802 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@RafaelGSS
Copy link
MemberAuthor

RafaelGSS commented Apr 26, 2022

Landed in d8460de

targos pushed a commit that referenced this pull request Apr 28, 2022
@RafaelGSS@targos
doc: elevate node-clinic diagnostic tier
2d76f72
PR-URL: #42802 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@targostargos mentioned this pull request May 2, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@RafaelGSS@juanarbol
doc: elevate node-clinic diagnostic tier
2444d5c
PR-URL: #42802 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@juanarboljuanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@RafaelGSS@danielleadams
doc: elevate node-clinic diagnostic tier
dd58892
PR-URL: #42802 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@RafaelGSS@targos
doc: elevate node-clinic diagnostic tier
5c6c86a
PR-URL: #42802 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@RafaelGSS@targos
doc: elevate node-clinic diagnostic tier
92d7214
PR-URL: #42802 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@RafaelGSS@guangwong
doc: elevate node-clinic diagnostic tier
85e37e2
PR-URL: nodejs/node#42802 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
gireeshpunathil added a commit to gireeshpunathil/node that referenced this pull request Mar 12, 2023
@gireeshpunathil
doc: amend support tier qualifier
d5b971f
Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: nodejs#42802
gireeshpunathil added a commit that referenced this pull request Mar 13, 2023
@gireeshpunathil
doc: amend support tier qualifier
59dd9ca
Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: #42802 PR-URL: #42805 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Mar 13, 2023
@gireeshpunathil@targos
doc: amend support tier qualifier
e5ffba0
Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: #42802 PR-URL: #42805 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
@gireeshpunathil@targos
doc: amend support tier qualifier
94882f5
Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: #42802 PR-URL: #42805 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@gireeshpunathil@danielleadams
doc: amend support tier qualifier
0e3077d
Amend Tier 3 category definition to remove a tentative clause and introduce a more concrete one. Refs: #42802 PR-URL: #42805 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Re-evaluate node-clinic tool tier-list

9 participants

@RafaelGSS@nodejs-github-bot@richardlau@gireeshpunathil@mhdawson@mcollina@jasnell@lpinca@RaisinTen