test: add test for tls.parseCertString#4283
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
evanlucas added tls 
Member
There was a problem hiding this comment.
s/Joyent/Node.js Foundation/? That also tests if blanks in the O field are parsed correctly.
ContributorAuthor
There was a problem hiding this comment.
Good call. I had copied that directly from the comment above the actual function but will change.
Member
bnoordhuis commented Dec 15, 2015
LGTM with a suggestion. |
evanlucasforce-pushed the parseCertStringTest branch from 56865e5 to 7c1a04cCompare
ContributorAuthor
evanlucas commented Dec 15, 2015
It does not currently have any explicit tests to verify the behavior. PR-URL: nodejs#4283 Reviewed-By: Ben Noordhuis <[email protected]>
evanlucasforce-pushed the parseCertStringTest branch from 7c1a04c to 0b9c3a3CompareContributorAuthor
evanlucas commented Dec 15, 2015
Landed in 0b9c3a3. Thanks! |
evanlucas added a commit that referenced this pull request Dec 15, 2015
It does not currently have any explicit tests to verify the behavior. PR-URL: #4283 Reviewed-By: Ben Noordhuis <[email protected]>
Closed
evanlucas added a commit that referenced this pull request Dec 30, 2015
It does not currently have any explicit tests to verify the behavior. PR-URL: #4283 Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
It does not currently have any explicit tests to verify the behavior. PR-URL: #4283 Reviewed-By: Ben Noordhuis <[email protected]>
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
It does not currently have any explicit tests to verify the behavior. PR-URL: nodejs#4283 Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It does not currently have any explicit tests to verify the behavior.