perf_hooks: return different functions in timerify

[himself65]

Fixes: #42742

[nodejs-github-bot]

Review requested:

• @nodejs/performance

[himself65]

I'm thinking to remove the cache feature.
There're two main reasons:

1. Adding a private symbol field into the user's data is not a good idea. Because we don't know what kind of data will pass in

For example:

constperf_hooks=require('perf_hooks')functionf(){console.log('hello, world!')}Object.freeze(f)perf_hooks.performance.timerify(f)

/Users/himself65/Code/node/out/Debug/node /Users/himself65/Code/test/index.js node:internal/perf/timerify:123 ObjectDefineProperties(fn,{^ TypeError: Cannot define property Symbol(kTimerified), object is not extensible at defineProperties (<anonymous>) at Performance.timerify (node:internal/perf/timerify:123:5)

2. caching by default will increase unnecessary complexity.

The original PR(#37136) only has 1 parameter which is fn. At this time, cache a function is very simple. However, the next PR adds one more parameter histogram(#37475), and this causes unexpected code behavior inconsistent today.
So if we finished a perfect cache system for now and merge it. But what if we add one more parameter in the future?

Moreover, I think users could cache a timerify function if they want. So I will remove cache stuff in this PR

/cc @nodejs/performance

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/43732/

[himself65]

quashed

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/43785/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/42854 ✔ Done loading data for nodejs/node/pull/42854 ----------------------------------- PR info ------------------------------------ Title perf_hooks: return different timerified function in timerify (#42854) Author Himself65 (@Himself65) Branch Himself65:20220423-fix-perfomance-timerify -> nodejs:master Labels author ready, perf_hooks, needs-ci Commits 1 - perf_hooks: return different timerified function in timerify Committers 1 - Himself65 PR-URL: https://github.com/nodejs/node/pull/42854 Fixes: https://github.com/nodejs/node/issues/42742 Reviewed-By: Matteo Collina Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42854 Fixes: https://github.com/nodejs/node/issues/42742 Reviewed-By: Matteo Collina Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - perf_hooks: return different timerified function in timerify ℹ This PR was created on Sun, 24 Apr 2022 22:39:46 GMT ✔ Approvals: 2 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/42854#pullrequestreview-955517509 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/42854#pullrequestreview-955519178 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-04-30T22:10:34Z: https://ci.nodejs.org/job/node-test-pull-request/43800/ - Querying data for job/node-test-pull-request/43800/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/2254578403

[himself65]

Let me think... How to use commit-queie🤔

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/42854 ✔ Done loading data for nodejs/node/pull/42854 ----------------------------------- PR info ------------------------------------ Title perf_hooks: return different timerified function in timerify (#42854) Author Himself65 (@Himself65) Branch Himself65:20220423-fix-perfomance-timerify -> nodejs:master Labels author ready, perf_hooks, needs-ci Commits 1 - perf_hooks: return different timerified function in timerify Committers 1 - Himself65 PR-URL: https://github.com/nodejs/node/pull/42854 Fixes: https://github.com/nodejs/node/issues/42742 Reviewed-By: Matteo Collina Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42854 Fixes: https://github.com/nodejs/node/issues/42742 Reviewed-By: Matteo Collina Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - perf_hooks: return different timerified function in timerify ℹ This PR was created on Sun, 24 Apr 2022 22:39:46 GMT ✔ Approvals: 2 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/42854#pullrequestreview-955517509 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/42854#pullrequestreview-955519178 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-05-01T19:21:48Z: https://ci.nodejs.org/job/node-test-pull-request/43800/ - Querying data for job/node-test-pull-request/43800/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/2254620326

[himself65]

Landed in 3d0fc13

[himself65]

What's more, I found that the commit queue always failed because the commit message tool didn't consider the Co-author-by field to the tailer.
So the final check failed