Skip to content

assert: make assert.fail less affected by prototype tampering#42918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 2 commits into from
May 2, 2022
Merged

assert: make assert.fail less affected by prototype tampering #42918

nodejs-github-bot merged 2 commits into from
May 2, 2022

Conversation

@aduh95
Copy link
Contributor

@aduh95aduh95 commented Apr 29, 2022

Before this change:

node:internal/assert/assertion_error:443 ObjectDefineProperty(this, 'name',{^ TypeError: Invalid property descriptor. Cannot both specify accessors and a value or writable attribute, #<Object> at defineProperty (<anonymous>) at new AssertionError (node:internal/assert/assertion_error:443:5) at compareExceptionKey (node:assert:626:19) at expectedException (node:assert:693:9) at expectsError (node:assert:847:3) at Function.throws (node:assert:902:3) at Object.<anonymous> (…/test/parallel/test-assert-fail.js:43:8) at Module._compile (node:internal/modules/cjs/loader:1105:14) at Module._extensions..js (node:internal/modules/cjs/loader:1159:10) at Module.load (node:internal/modules/cjs/loader:981:32) Node.js v19.0.0-pre

With this change:

node:assert:170 throw err; ^ AssertionError [ERR_ASSERTION] at [eval]:1:8 at Script.runInThisContext (node:vm:129:12) at Object.runInThisContext (node:vm:305:38) at node:internal/process/execution:76:19 at [eval]-wrapper:6:22 at evalScript (node:internal/process/execution:75:60) at node:internal/main/eval_string:27:3{generatedMessage: true, code: 'ERR_ASSERTION', actual: undefined, expected: undefined, operator: 'fail' } Node.js v19.0.0-pre

@nodejs-github-botnodejs-github-bot added assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run. labels Apr 29, 2022
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 30, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 30, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43787/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2022
@nodejs-github-botnodejs-github-bot merged commit 2b41f59 into nodejs:masterMay 2, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 2, 2022

Landed in 2b41f59

@aduh95aduh95 deleted the assert-fail-prototype-tampering branch May 2, 2022 17:47
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
@aduh95@RafaelGSS
assert: make assert.fail less affected by prototype tampering
e74a8da
PR-URL: #42918 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@RafaelGSSRafaelGSS mentioned this pull request May 10, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@aduh95@juanarbol
assert: make assert.fail less affected by prototype tampering
c6a814c
PR-URL: #42918 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@juanarboljuanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@aduh95@danielleadams
assert: make assert.fail less affected by prototype tampering
49f471a
PR-URL: #42918 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@aduh95@targos
assert: make assert.fail less affected by prototype tampering
ba06361
PR-URL: #42918 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@aduh95@targos
assert: make assert.fail less affected by prototype tampering
7f8f83d
PR-URL: #42918 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@targostargos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@aduh95@guangwong
assert: make assert.fail less affected by prototype tampering
49cf76c
PR-URL: nodejs/node#42918 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes

@cjihrigcjihrigcjihrig approved these changes

@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes

Assignees

No one assigned

Labels

assertIssues and PRs related to the assert subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95@nodejs-github-bot@targos@cjihrig@VoltrexKeyva